p1e: A3 gate emits every shadcn worked example; consume dspack-emit 0.3.2#24
Merged
Conversation
….3.2 The studio side of P1.E: build.ts's shadcn branch emitted only examples[0], which is exactly why two nominally-mapped sub-families (table, card) could refuse for months without any gate noticing — the example that would have caught it was never emitted. Every worked example now emits (exit 4 on refusal, per-example labeling on warnings); the set grows with the contract through check:sync. Fail-first, against the published dspack-emit 0.3.1: shadcn surface emission failed (ex.support-ticket-queue): unknown component 'table-caption': not a mapped component of the 'shadcn/ui — A2UI catalog (compiled from dspack)' profile build exit code: 4 dspack-emit 0.3.2 (feat/profile-parity, merged) adds the subTable and subFlatten parent strategies plus the subCoverage completeness invariant. The dependency is pinned to 0.3.2 here; lockfile follows once the package is published (publishing is owner-gated — no trusted-publishing workflow in dspack-emit). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Verified against the npm tarball (subTable/subFlatten in the compiled emitter, subCoverage in the profile). Lockfile delta is solely the dspack-emit 0.3.1 -> 0.3.2 lines. Gates on the published package: contracts build:catalogs with the all-examples A3 gate green (ticket-queue emits with three per-cell badge-flatten warnings + the composition summary), drift-check and check:sync clean, pnpm -r typecheck/test green, local Playwright 106 passed / 4 skipped, production config 86 passed. All six P1.1 recordings emit through the published package: five at 4 columns x 3 rows, the skeletal fifth at 1x1. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the contracts build gate to fully exercise the shadcn/ui contract’s worked examples (addressing the prior partial-emission gap) and bumps the studio’s @aestheticfunction/dspack-emit dependency to the paired 0.3.2 release.
Changes:
- Bump
@aestheticfunction/dspack-emitfrom0.3.1to0.3.2(package + lockfile). - Emit every shadcn worked example surface during
packages/contracts/src/build.tsexecution, labeling warnings/errors per example and preservingexamples[0]as the A3 sample input.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pnpm-lock.yaml | Locks @aestheticfunction/dspack-emit@0.3.2 and updates the contracts importer to use it. |
| packages/contracts/src/build.ts | Expands shadcn surface emission from only examples[0] to all worked examples with per-example labeling and consistent exit behavior. |
| packages/contracts/package.json | Bumps contracts’ direct dependency on @aestheticfunction/dspack-emit to 0.3.2. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Studio side of P1.E, paired with dspack-emit #21 (merged, version 0.3.2 in-repo).
The gate that should have caught P1.E now exists:
build.ts's shadcn branch emitted onlyexamples[0]— the precise reason two nominally-mapped sub-families could refuse for months unnoticed. Every worked example now emits through the A3-stage gate (exit 4 on refusal, warnings labeled per example), and the set grows with the contract viacheck:sync.Fail-first (against published 0.3.1):
Draft until
@aestheticfunction/dspack-emit@0.3.2publishes (owner-gated — no trusted-publishing workflow in that repo;npm publishfrom its main). Then: lockfile bump, full gates re-run, undraft.🤖 Generated with Claude Code