sync: consume shadcn contract v2.3.0 (record-collection)#23
Merged
Conversation
Byte-copy of dspack #23 per the P0 merge protocol: canonical change landed upstream first; this PR carries the identical consumption. The shadcn catalogs re-emit through the ordinary ajv gates unchanged in shape (no new components — governance only). No runtime change: the studio still generates and lints under the astryx catalog; the design-swap still renders the astryx catalog with shadcn visuals. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the consumed shadcn/ui dspack contract to v2.3.0, adding the new record-collection intent (plus associated rules and an example surface) to guide/validate semantic data-table usage in the catalog.
Changes:
- Bump shadcn contract version from 2.2.0 → 2.3.0.
- Add
record-collectionintent linked to the existingdata-table-with-row-actionspattern. - Introduce record-collection rules (requires
table, enforces header/body structure and a caption) and add an example surface (ex.support-ticket-queue).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "appliesTo": { "intents": ["record-collection"] }, | ||
| "component": "table", | ||
| "requiredSubComponents": [{ "id": "table-caption", "min": 1 }], | ||
| "rationale": "The data-table-with-row-actions pattern requires an accessible name via TableCaption or an aria-label. The pattern permits either; the contract can only govern the declarative form, so the caption is the enforceable floor — an aria-label alternative is legitimate but inexpressible in current rule types and remains guidance.", |
| { "component": "table-cell", "text": "Cannot export billing statement" }, | ||
| { | ||
| "component": "table-cell", | ||
| "children": [{ "component": "badge", "props": { "variant": "destructive" }, "text": "Urgent" }] |
This was referenced Jul 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second link of the P1.1 four-repo sequence, per the P0 merge protocol: dspack #23 landed the canonical change; this PR carries the byte-identical consumption (
cmp-verified against dspack main).Governance-only change (no new components): the shadcn catalogs re-emit through the ordinary ajv gates clean;
check:syncgreen; no studio runtime change (generation/linting stays on the astryx catalog, design-swap unchanged).Downstream still queued: dspack-gen fixture re-sync + goldens + recordings → ds-mcp example re-sync.
🤖 Generated with Claude Code