fix: harden Greater Realm preflight verification - #218
Merged
Conversation
ael-dev3
marked this pull request as ready for review
August 26, 2026 00:29
ael-dev3
force-pushed
the
codex/greater-realm-preflight-ci-20260825
branch
from
August 26, 2026 00:32
260166b to
7f7ec24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
CI preflight and fail-closed verification hardening for the approved Greater Realm final rollout. The committed readiness report remains NOT READY until protected GitHub evidence closes every listed stop condition.
This PR:
production-admin-v1cutover-receipt default and locks that contract with a regression testIt does not change gameplay behavior, open any import/activation/presentation/notification gate, deploy, admit players, send notifications, or merge PR #193.
Failure and fix
At exact head
2edccdb37b3ba94303b95172f36dde1059c5cb45,verifycompleted 5,108 tests successfully and failed one teardown withENOTEMPTYwhile removing a temporary.gitdirectory. The oversized tracked-listing assertion itself behaved correctly.Root cause: fail-fast
Promise.allreturned after the boundedls-filesrejection while seven read-only sibling Git processes were still settling. The fix tree first landed at unsigned exact head260166b7e3461775e3d88a7180b4159b5e6d6152, where all five protected checks passed. A signature-only rebase of the same nine commits produced signed head7f7ec2429cbdb4df76fe39104df334570d1e07cb; both heads have identical tree1bb0fedec7a75b63e116552e7b7e9d57b7fba75f, and GitHub verifies all nine commits in that history. Current exact heada627427c2a0c62b3e5e2e7a5736541fae14d1075adds only the separately reviewed runbook-path correction and its contract test; GitHub also verifies that tenth commit. The runtime/auth-bridge tree:Promise.allSettledin both deployers before returning or throwingaa6a24ac7decb83d0a0b260070ad81abea0af9bfaececf3cdb0c5de742f00e6dAt
a627427c, the runbook default now exactly matches publisher, import, relocation, bootstrap, and C4:~/.warpkeep/private/production-admin-v1/greater-realm-cutover-receipts. Its new contract test failed against the old text and passed after the one-line correction.Local evidence at
a627427cpre-generation; package remains0.3.43d9c1732lineage maps to reviewed adaptations through8200539,4fbe666,8d74c717, and98a3636The exhaustive prepared-workflow mutation matrix exceeds the managed local runner lifecycle and also encounters a pre-existing macOS sandbox Git stderr warning. Neither condition is waived; the full protected GitHub suite remains required.
Merge gate
Do not merge until all five protected-main checks are green on current exact head
a627427c2a0c62b3e5e2e7a5736541fae14d1075:verify,auth-bridge,spacetimedb-module,analyze, andCodeQL. Re-authenticate current main, the synthetic merge result, conversations, and the complete 18-file diff before an author-performed squash merge. A successful PR run is not a substitute for the separately required same-SHA push-triggered Verify run after protected-main integration.PR #193 remains the separate final integration record. At audited head
d9c1732, no source delta remains to port and its stale conflicts must not be resolved merely to make it mergeable. If its head changes, audit and adapt only the new delta; if it remains exact, close it as superseded last only after C7, sequential admission/reconciliation, and final live receipts.