Repository navigation
chore: update to ecl-lsp 1.6.2 and Monaco 0.57.0 - #5
Merged
Merged
Conversation
- ecl-core 1.1.2 -> 1.6.1: refinement attribute-name operators, alternate identifiers, comparisons and member fields are no longer dropped by Format/Simplify ECL; top/bottom of set operators now parse. - ecl-editor standalone bundle rebuilt from the v1.6.1 tag: concept typeahead now returns search results on the request that asked, fixing suggestions that only appeared (stale) on the next keystroke. - Monaco CDN 0.52.2 -> 0.57.0, the version ecl-lsp tests against. - esbuild 0.28.1 -> 0.28.2 (build-time only). - Regression tests for the ecl-core formatting/parsing fixes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The ECL Workbench loads Monaco 0.57.0 from the jsDelivr CDN at runtime. It is not bundled, but it is a third-party component the app depends on, so record its MIT license alongside the other ecl-lsp dependencies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- ecl-editor standalone bundle rebuilt from the v1.6.2 tag: the hint bar now shows ⌃+Space for autocomplete on macOS instead of ⌘+Space, which is Spotlight and never triggered autocomplete (aehrc/ecl-lsp#139). - ecl-core ^1.6.1 -> ^1.6.2 (no code changes; regenerated bundle is identical). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/package.json, regeneratedecl-core-bundle.js)< 404684003: << 363698007 = …was reformatted to< 404684003: 363698007 = …, changing the meaning.363698007 >= #10), alternate identifiers and member field selections now parse and survive formatting; top/bottom of set operators (!!>,!!<) are supported.v1.6.2tag (npm run build:standalone). Picks up fix(ecl-editor-core): deliver concept search results on the request that asked ecl-lsp#137: concept typeahead in the ECL Workbench now returns search results on the request that asked. Before, results only appeared on the next keystroke and were for the previous text, so typeahead often looked like it never activated.npm audit: 0 vulnerabilities).[Unreleased]updated.Testing
xcodebuild buildsucceeds; unit test plan: 557 tests, 0 failures.4 new
ECLBridgeTestsregression tests for the attribute-operator and numeric-comparison fixes (confirmed against the old bundle: it drops the operator and fails to parse the comparison).Ran the Workbench HTML (Monaco 0.57 + new bundle) in Chromium and WebKit: typing
appendicafter363698007 =and pausing shows Appendicitis / Appendicectomy / … from a single debounced$expand; Ctrl+Space manual trigger works; no console errors.Not yet exercised inside the running app's
WKWebView— worth a quick manual check of the ECL Workbench before merging.Shortcut hint fixed (ecl-lsp 1.6.2, fix(ecl-editor, ecl-editor-react): advertise Ctrl+Space for autocomplete on macOS ecl-lsp#139): the Workbench hint bar now shows
⌃+Spacefor autocomplete on macOS instead of⌘+Space, which is Spotlight.Follow-ups
### Fixedsection under[Unreleased]in CHANGELOG.md, so whichever merges second needs that conflict resolved by keeping both entries.🤖 Generated with Claude Code