Repository navigation
docs: tighten two lines from the #2 review - #50
Merged
Merged
Conversation
…mdcode, with running the checker
|
This PR changes 1 package but has no bump file, so this check is failing. Changed package(s) without a bump file:
If these changes should be released, add a bump file describing the version bump. If no release is needed (e.g. a dependency-only or dev-only change), add an empty bump file to acknowledge that intent — that satisfies this check without bumping any package. pnpm exec bumpy add # describe a release
pnpm exec bumpy add --empty # acknowledge no release is neededOr directly on GitHub: add a bump file · add an empty bump file. This comment is maintained by bumpy. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Follow-up to #49, which merged before this commit was pushed.
Summary
The first line was worded as a fact about CI. It's a recommendation. The second gives the credit to the copyable script: mdcode itself only extracts the blocks, and the script runs the checker (Validating Runnable Snippets in CI, step 2).
Evidence
The pre-push
pnpm checkpasses.Merge Danger
Door: two-way
Blast Radius: docs