Add character count in text area - #1972
shravani-0811 wants to merge 2 commits into
Conversation
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
| public static final String PN_SHOW_AS_POPUP = "showAsPopup"; | ||
| public static final String PN_TEXT_IS_RICH = "textIsRich"; | ||
| public static final String PN_MULTILINE = "multiLine"; | ||
| public static final String PN_SHOW_CHARACTER_COUNT = "showCharacterCount"; |
There was a problem hiding this comment.
namespace this with fd: and this also needs to be implemented in headless for text area
| * | ||
| * @return {@code true} if the character count should be shown, {@code false} if not, or {@code null} if not configured or | ||
| * not applicable | ||
| * @since com.adobe.cq.forms.core.components.models.form 5.13.0 |
There was a problem hiding this comment.
this version should be as per the current package.info file
| "required", | ||
| "rules", | ||
| "screenReaderText", | ||
| "showCharacterCount", |
There was a problem hiding this comment.
this is not right, any schema changes should go via af2-docs repo which is inside git corp, revert.
Also this is a custom property, so it should not be part of the spec as well (only OOTB properties are part of the spec)
| textarea.cmp-adaptiveform-textinput__widget { | ||
| height: @textarea-height; | ||
| } | ||
| .cmp-adaptiveform-textinput__charcount { |
There was a problem hiding this comment.
We can't give color in OOTB less file, it should come via theme. This should just drive basic usability of the feature
There was a problem hiding this comment.
[EDIT] looks like this is in examples, so we are good
| // "Show character count" is only applicable to multi line fields; hidden until "Allow multiple lines" is checked | ||
| cy.get(".cmp-adaptiveform-textinput__showcharactercount").parent('div').invoke('css', 'display').should('equal', 'none'); | ||
| cy.get("[name='./multiLine']").click({force: true}); | ||
| cy.get(".cmp-adaptiveform-textinput__showcharactercount").parent('div').invoke('css', 'display').should('equal', 'block'); |
There was a problem hiding this comment.
Can you also add runtime test case ? Also in authoring, char count won't work and it would display 0/max length, even that test needs to be added
3 participants
Description
Enhancing the text area to show the character count.
Related Issue
https://jira.corp.adobe.com/browse/FORMS-13475
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: