FORMS-26424-Add Next Gen Dynamic Media (NGDM) support to the StaticImage component by pankaj-parashar · Pull Request #1965 · adobe/aem-core-forms-components

pankaj-parashar · 2026-08-20T07:37:20Z

Ports the NGDM asset support from adobe/aem-core-wcm-components#2481 to the Adaptive Forms StaticImage (form/image v1) component. When the fileReference is an NGDM asset (/urn:...) and the NextGenDynamicMediaConfig OSGi service is enabled, the delivery URL is built directly instead of resolving a DAM rendition. Bumps aem-sdk-api to 2023.9.13665 to pick up the NextGenDynamicMediaConfig API, and enables the NGDM asset picker on the component's file upload dialog field.

changes behind : FT_FORMS-26424

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes and the overall coverage did not decrease.
All unit tests pass on CircleCi.
I ran all tests locally and they pass.

Ports the NGDM asset support from adobe/aem-core-wcm-components#2481 to the Adaptive Forms StaticImage (form/image v1) component. When the fileReference is an NGDM asset (/urn:...) and the NextGenDynamicMediaConfig OSGi service is enabled, the delivery URL is built directly instead of resolving a DAM rendition. Bumps aem-sdk-api to 2023.9.13665 to pick up the NextGenDynamicMediaConfig API, and enables the NGDM asset picker on the component's file upload dialog field. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

adobe-bot · 2026-08-20T08:21:52Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2026-08-20T08:23:49Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

codecov · 2026-08-20T08:28:22Z

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...nents/internal/models/v1/form/StaticImageImpl.java	83.33%	0 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

rismehta · 2026-08-25T04:25:56Z

+    private static final String PATH_PLACEHOLDER_SEO_NAME = "{seo-name}";
+    private static final String PATH_PLACEHOLDER_FORMAT = "{format}";
+    private static final String DEFAULT_NGDM_ASSET_EXTENSION = "jpg";
+    private static final int DEFAULT_NGDM_ASSET_WIDTH = 640;


why is 640 default and jpg default ?

Hi @rismehta ,
If we do not send any width the Dynamic Media Open API sends the default width of 1024, which dominates the screen and this is how it looks:

But with width default value = 640 , the image renders at a size that coexists properly with the rest of the form's components.

Since the authoring canvas has no independent scaling constraint, the size of the image canbe managed by theme and styling, We can keep this default to 640

I mean how did we choose this magic numbers ? is this based on some customer data or existing proven patterns ?

@rismehta , this was referred from Core Component Image - Dynamic Integration implementation.
https://github.com/adobe/aem-core-wcm-components/blob/main/bundles/core/src/main/java/com/adobe/cq/wcm/core/components/internal/models/v3/ImageImpl.java#L78

widely-used breakpoint values — e.g. Tailwind CSS's default breakpoints are sm=640px, md=768px, lg=1024px, xl=1280px, 2xl=1536px.
In responsive-image-serving conventions specifically (Cloudinary/Imgix-style breakpoint guides), 640 and 1024 are common rungs in a typical image-width ladder

- Extract Next Gen Dynamic Media (NGDM) URL-resolution logic out of StaticImageImpl into a shared NgdmImageUtils class - Add a Sling Model JSON-exporter test proving the resolved NGDM delivery URL is exposed as "value" and fd:repoPath is correctly absent - Fix multi-dot seo-name filenames (e.g. "product.hero.png") resolving to the wrong delivery URL/extension by splitting on the last dot, not the first - Tighten isNgdmImageReference() to require a non-empty asset-id and seo-name segment, avoiding a NoSuchElementException on malformed references - Mark com.adobe.cq.ui.wcm.commons.config as an optional OSGi import so the bundle still resolves on installations without this Cloud Service API

- Add FT_NGDM_IMAGE_PICKER (FT_FORMS-26424) constant, following the existing FeatureToggleConstants pattern - Split the Image dialog's file widget into two mutually-exclusive variants gated by granite:rendercondition/featuretoggle: NGDM picker enabled shows the Pick (Local/Remote) UI, disabled shows the original Browse Assets/Upload UI - Gate StaticImageImpl's NGDM URL resolution and fd:repoPath exclusion behind the same toggle via ComponentUtils.isToggleEnabled(), so a saved NGDM reference is treated as a plain fileReference when the toggle is off - Add toggle-enabled/disabled test coverage, following the same System.setProperty/@AfterEach pattern already used in FragmentImplTest

Runs the project's eclipse-formatter.xml rules over NgdmImageUtils.java and its test, which had not been formatted before commit and were failing the verify-code-formatting build step on both Java 11 and 21 CI jobs. Whitespace-only change, no logic changes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

…tream changes and fix stale exporter-json/recaptcha CI check

adobe-bot · 2026-09-21T07:13:28Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2026-09-21T07:14:09Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2026-09-21T07:22:48Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

adobe-bot · 2026-09-21T07:26:16Z

Accessibility Violations Found

Id	Impact
aria-required-attr	critical
empty-heading	minor
label-title-only	serious
target-size	serious

rismehta · 2026-09-22T10:11:21Z

+ * Utility methods for resolving Next Gen Dynamic Media (NGDM) asset references
+ * (of the form {@code /urn:aaid:aem:<asset-id>/<seo-name>.<format>}) into delivery URLs.
+ */
+public final class NgdmImageUtils {


Why is utils inside model folder ? Can you place this in appropriate package

Moved it to bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/internal/form/NgdmImageUtils.java

rismehta · 2026-09-22T10:12:00Z

+        // must have a non-empty asset-id segment and a non-empty seo-name segment, i.e.
+        // "/urn:<asset-id>/<seo-name>[.<format>]", otherwise buildNgdmImageSrc() has nothing to parse.
+        String withoutLeadingSlash = fileReference.substring(1);
+        int slashIndex = withoutLeadingSlash.indexOf('/');


use substringAfter here

rismehta · 2026-09-22T10:12:17Z

+     */
+    public static String buildNgdmImageSrc(String fileReference, NextGenDynamicMediaConfig nextGenDynamicMediaConfig) {
+        String withoutLeadingSlash = fileReference.substring(1);
+        int slashIndex = withoutLeadingSlash.indexOf('/');


Make use of StringUtils library for string related operations

rismehta · 2026-09-22T10:12:42Z

+            .replace(PATH_PLACEHOLDER_SEO_NAME, assetName)
+            .replace(PATH_PLACEHOLDER_FORMAT, assetExtension);
+
+        return "https://" + nextGenDynamicMediaConfig.getRepositoryId() + imageDeliveryPath


Why we have hardcoded this to https, is this configurable ? Should this come via cloud configuration ?

Hi @rismehta ,

this code is based on aem-core-wcm-components's implementation of Dynamic Media Integration. Hence copied the same pattern of hardcoding "https" : [1][2]

NextGenDynamicMediaConfig interface (from aem-sdk-api) does not expose any schema/protocol , which we could have used

the official documentation of Dynamic Media [3], states it requires https to function

The integration we do in cloud manager / confgmgr to connect to dynamic media server does not take any protocol input. The server url is provided as follows : delivery-pxxxxx-eyyyyyy.adobeaemcloud.com
Hence can't configure from here. [4]

Therefore we kept it as is.

[1]https://github.com/adobe/aem-core-wcm-components/blob/main/bundles/core/src/main/java/com/adobe/cq/wcm/core/components/internal/models/v3/NextGenDMImageURIBuilder.java#L137
[2]https://github.com/adobe/aem-core-wcm-components/blob/main/bundles/core/src/main/java/com/adobe/cq/wcm/core/components/internal/models/v3/ImageImpl.java#L267
[3] https://experienceleague.adobe.com/en/docs/experience-manager-core-components/using/developing/remote-assets#https
[4] https://experienceleague.adobe.com/en/docs/experience-manager-cloud-service/content/assets/dynamicmedia/dynamic-media-open-apis/integrate-remote-approved-assets-with-sites#pre-requisites-sites-integration

rismehta · 2026-09-22T10:13:09Z

+     * which falls back to the original Browse Assets/Upload UI in that case.
+     */
+    private boolean isNgdmReferenceAndFeatureEnabled() {
+        return ComponentUtils.isToggleEnabled(FeatureToggleConstants.FT_NGDM_IMAGE_PICKER)


Since this is system toggle, you also need to enable this in aemds far

rismehta

check comments, create PR against dev

lovelymandal16 · 2026-09-23T08:35:51Z

Addressed the comments on the dev PR . Closing this one. #1989

rismehta reviewed Aug 25, 2026

View reviewed changes

Comment thread ...rc/main/java/com/adobe/cq/forms/core/components/internal/models/v1/form/StaticImageImpl.java Outdated

rismehta reviewed Aug 25, 2026

View reviewed changes

Comment thread ...rc/main/java/com/adobe/cq/forms/core/components/internal/models/v1/form/StaticImageImpl.java Outdated

rismehta reviewed Aug 25, 2026

View reviewed changes

Comment thread ...rc/main/content/jcr_root/apps/core/fd/components/form/image/v1/image/_cq_dialog/.content.xml

lovelymandal16 changed the title ~~Add Next Gen Dynamic Media (NGDM) support to the StaticImage component~~ FORMS-26424-Add Next Gen Dynamic Media (NGDM) support to the StaticImage component Sep 9, 2026

lovelymandal16 and others added 3 commits September 9, 2026 14:15

Merge origin/master into feature/dynamic-media-support to pick up ups…

51adf7d

…tream changes and fix stale exporter-json/recaptcha CI check

rismehta reviewed Sep 22, 2026

View reviewed changes

rismehta requested changes Sep 22, 2026

View reviewed changes

lovelymandal16 mentioned this pull request Sep 23, 2026

Add Next Gen Dynamic Media (NGDM) support to the StaticImage component #1989

Open

3 tasks

lovelymandal16 closed this Sep 23, 2026

Conversation

pankaj-parashar commented Aug 20, 2026 • edited by lovelymandal16 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

adobe-bot commented Aug 20, 2026

Accessibility Violations Found

Uh oh!

adobe-bot commented Aug 20, 2026

Accessibility Violations Found

Uh oh!

codecov Bot commented Aug 20, 2026

Codecov Report

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pankaj-parashar Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

adobe-bot commented Sep 21, 2026

Accessibility Violations Found

Uh oh!

adobe-bot commented Sep 21, 2026

Accessibility Violations Found

Uh oh!

adobe-bot commented Sep 21, 2026

Accessibility Violations Found

Uh oh!

adobe-bot commented Sep 21, 2026

Accessibility Violations Found

Uh oh!

rismehta Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rismehta left a comment

Choose a reason for hiding this comment

Uh oh!

lovelymandal16 commented Sep 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pankaj-parashar commented Aug 20, 2026 •

edited by lovelymandal16

Loading

pankaj-parashar Sep 21, 2026 •

edited

Loading

rismehta Sep 22, 2026 •

edited

Loading