feat: add reference_assets to product_card_detailed#5583
Open
garvitkaushik-123 wants to merge 1 commit into
Open
feat: add reference_assets to product_card_detailed#5583garvitkaushik-123 wants to merge 1 commit into
garvitkaushik-123 wants to merge 1 commit into
Conversation
Adds a typed `reference_assets` array to `product_card_detailed` so sellers can surface coverage maps, sample renders, environment photos, and media kits through a recognized schema slot rather than opaque extension fields. New schema: core/product-card-reference-asset.json - role enum: coverage_map, sample_render, environment_photo, media_kit, logo, other - asset: discriminated union over image, video, markdown, url assets - role_label: required when role is "other" Non-breaking: all fields optional, existing consumers unaffected. Closes adcontextprotocol#5539 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
The automated review encountered an issue (possibly reached max turns, timed out, or failed to post the final gh pr review). A human reviewer should take this PR.
This is an automated message from the Argus AI review workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reference_assets[]toproduct_card_detailedfor typed seller collateral (coverage maps, sample renders, environment photos, media kits)core/product-card-reference-asset.jsonwith closedroleenum (coverage_map,sample_render,environment_photo,media_kit,logo,other) androle_labelescape hatch forotherimage-asset,video-asset,markdown-asset,url-asset— reuses canonical asset primitives without pulling in the fullasset-union.json(which includes serving/tracking types inappropriate for product-card collateral)media-products.mdxwith reference assets section and examplePer @bokelley's direction: nested inside
product_card_detailed(Option B), not a new top-level field.Non-breaking: all fields optional, existing consumers unaffected.
Closes #5539
Test plan
npm run buildpasses (validates$refchains)minor(new optional array field)🤖 Generated with Claude Code