Repository navigation
Use less flash when the web workflow reads upload sizes and file times - #11626
Merged
Merged
Conversation
Content-Length and X-Timestamp are plain decimal, so read them with a small loop. This drops strtoull() from the link, and also strtoul() on boards where settings.c no longer uses it. Sec-WebSocket-Version was parsed but never read, so stop parsing it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
mikeysklar
marked this pull request as ready for review
October 18, 2026 19:51
dhalbert
approved these changes
Oct 18, 2026
dhalbert
left a comment
dhalbert
left a comment
Collaborator
There was a problem hiding this comment.
This is good. I was seeing if the small integer parser could be used elsewhere, or could be combined with what's in settings, but this needs 64-bit results sometimes, etc.
In the long run these might be turned into utility routines that could be shared, but right now there's no one to share them with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The web workflow reads upload sizes and file times with a small loop instead of
strtoul().Why
It saves flash, following @dhalbert's note on #11620 that only the web workflow still used
strtoul().It saves the most on top of #11620.
.binbytes)Expect: 100-continueWritten with Claude Code.