Move XU4 detection above hardware field check#416
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes ODROID XU4 chip detection on Linux by ensuring the device-tree compatible string is checked before relying on the /proc/cpuinfo Hardware field, which can be too generic on that platform.
Changes:
- Add an early
/proc/device-tree/compatiblecheck forhardkernel,odroid-xu4to correctly identify the EXYNOS5422 chip. - Remove the later fallback check for
"odroid-xu4"inside thehardware is Nonebranch (since XU4 detection is now handled earlier via DT compatible).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ODROID XU4 has a generic hardware field value for /proc/cpuinfo, so it was never checking the /proc/device-tree/compatible value.