Repository navigation
Conversation
robjtede
marked this pull request as ready for review
November 3, 2026 16:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move CI/fmt (no matrix) to ubuntu-slim and use actions/checkout for that job. Keep Clippy and tests on Blacksmith because they compile Rust. Keep container build and promotion on Blacksmith because both run Docker builds or smoke tests.
GitHub documents slim as an unprivileged x64 container with 1 CPU, 5 GB RAM, 14 GB storage and a 15-minute job limit, available to public and private repositories. Its inventory includes Git, Node, curl and archive tools; the existing steps install Rust and just. Sources: https://docs.github.com/en/actions/reference/runners/github-hosted-runners and https://github.com/actions/runner-images/blob/main/images/ubuntu-slim/ubuntu-slim-Readme.md.
Validation:
just fmt-checkpassed locally. Both current-head workflows completed successfully: CI https://github.com/actix/github-release-router/actions/runs/41637375976 and container https://github.com/actix/github-release-router/actions/runs/41637375762. Formatting, Clippy, tests and container smoke tests passed. Reusable checks and image promotion were intentionally skipped for the PR event. No publishing or deployment was triggered. No observed job failures, timeouts, capacity cancellations or rerun API rejections. Clippy and test results on reruns were carried forward, not new executions.Measurements: CI/fmt, no matrix. Seconds are job completed_at minus started_at; queue time is excluded and was not measured separately. Historical baseline runner is blacksmith-2vcpu-ubuntu-2404, NOT standard GitHub Ubuntu. Baseline cache hit state is unverified. All six measured formatting executions succeeded.
Baseline n=3, median 21s; slim n=3, median 35s. Median duration change is 100*(35/21-1) = +66.7% (+14s). This is a historical comparison with different source revisions, checkout actions, cache conditions and runner providers. The 367s historical outlier is retained and unexplained. No controlled same-code standard GitHub Ubuntu baseline was collected; do not attribute the entire difference to slim CPU performance. Slim installed Rust 1.99.1 during setup. No measurements remain pending.