fix: PathEscape project name in DMS to SQLE URLs#653
Open
LordofAvernus wants to merge 1 commit into
Open
Conversation
Encode project name path segments so Chinese project names work when DMS calls SQLE APIs that use project_name in the URL. Fixes actiontech/dms-ee#936
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
project_namein the path (db_service, CloudBeaver auto workflow).Test plan
Fixes actiontech/dms-ee#936
Description
对项目名称进行 URL 编码
修正 DMS 调用 SQLE API 路径构造
确保中文项目名称正常传递
Diagram Walkthrough
File Walkthrough
cloudbeaver.go
修复 Cloudbeaver 中项目名称 URL 编码问题internal/dms/biz/cloudbeaver.go
db_service.go
修复 DBService 中项目名称 URL 编码问题internal/dms/biz/db_service.go