Display 3 metrix#854
Merged
Merged
Conversation
Reintroduced the first appearance and last receive timestamp columns in the SQL management table, including their respective render functions for formatting timestamps. Ensured the occurrence count column remains sortable, improving the overall functionality and user experience of the table.
Reintroduced the sorting functionality in the SQLEEIndex component tests, ensuring the filter data with sort test case is active. Updated the snapshot to reflect the new sortable columns, including occurrence count and timestamps, improving test coverage and alignment with the latest UI changes.
Updated snapshots to reflect the addition of new sortable columns in the SQL management table, including occurrence count and timestamps. This change improves test coverage and aligns with recent UI updates, ensuring accurate representation of the component's functionality.
Coverage report
Test suite run success2301 tests passing in 628 suites. Report generated by 🧪jest coverage report action from fcfa4ae |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
关联的 issue
https://github.com/actiontech/sqle-ee/pull/3017
设计说明文档：https://actiontech.feishu.cn/docx/Z4q1dic16oJZcJxea16cn3K0nKc
描述你的变更
SQL 管控列表恢复展示「出现数量 / 初次出现时间 / 最后一次出现时间」三列，对接后端列表接口已返回的
fp_count、first_appear_timestamp、last_receive_timestamp；后端未写入时前端按空值展示为-，不造数。主要改动：
SQLEEIndex/column.tsx）：恢复三列并接入既有 i18nfp_countfirst_appear_timestamp（formatTime）last_receive_timestamp（formatTime）sorter，通过现有sort_field/sort_order传给列表接口（与后端fp_count | first_appear_timestamp | last_receive_timestamp对齐）fp_count的断言不改接口契约与 API 客户端；字段类型与文案本已存在，仅恢复列表展示能力。
影响范围：SQL 管控列表页（EE）；依赖后端 enterprise 列表接口返回上述字段。
确认项（pr提交后操作）
Tip
请在指定复审人之前，确认并完成以下事项，完成后✅
not_compatibleneed_update_doc建议自测关注点：
-）sort_field/sort_order正确且列表顺序变化0或无效时间