fix(docker): build deployment image from source - #23
Open
RerankerGuo wants to merge 1 commit into
Open
Conversation
Build the frontend in a dedicated Node stage so self-hosted images no longer serve the redirect-only tracked dist bundle. Exclude local build artifacts and metadata from the Docker context. Closes acmenlei#17 Test: npm ci && npm run build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #17.
The Docker image currently copies the repository's tracked
dist/directory. Itsindex.htmlis a historical deployment stub that redirects every self-hosted request tohttps://codecv.top, so the documented local Docker deployment never serves the local application.Changes
dist/into the existing Apache runtime imageThis keeps the runtime image static and small while removing the tracked deployment artifact as a source of truth.
Verification
npm cinpm run builddist/index.htmlcontains a module entry point and nolocation.href/codecv.topredirect/app/dist/into ApacheDocker itself is not available in the local test environment, so the container was not started end to end. The exact build-stage commands were run from a clean archive of
master.Scope
dist/files are committed