Add unit and regression tests for issues 499, 486, 488, and 485#535
Merged
Chucks1093 merged 7 commits intoJul 5, 2026
Merged
Conversation
|
@Alaka-ibr Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
added 3 commits
July 2, 2026 11:28
… stable to rust-toolchain action (required parameter) - Import soroban_sdk::testutils::Ledger trait to fix E0599 compile error - Fix creator_fee_rotation_regression test to use correct register_creator API
…s in test snapshot files by accepting upstream changes which include the new whitelist parameter in register_creator API
Contributor
|
Please can you fix CI |
…rParams API After merging upstream/main, the register_creator function signature changed to use RegisterCreatorParams struct and added whitelist parameter. Updated the test to match the new API.
…s struct Three test files still used the old flat positional calling convention for register_creator. Updated key_supply.rs, locked_allocation_claimed_view_regression.rs, and quadratic_curve_symmetry_regression.rs to pass RegisterCreatorParams as the first argument and include the new whitelist Option<WhitelistConfig> as the 6th arg.
Contributor
|
A PR was merged before this one that changed how register_creator works. The old way took creator and handle as separate arguments. The new way packs them into one struct called RegisterCreatorParams. Three test files in this PR were still calling it the old way, so Rust rejected them at compile time. I updated all three files to use the new struct and also pass the two new optional arguments (co_creator, whitelist) that the same PR added. |
Advancing the ledger after contract creation caused the instance to appear archived in the test environment. Moving the ledger.set() call to before register_creator_keys ensures the TTL is fresh at the target sequence number.
Closed
4 tasks
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #499
Closes #486
Closes #488
Closes #485
Testing
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspaceChecklist
creator-keysunit/integration tests for every changed contract behavior, including failure paths for new or reachableContractErrorvariantscargo fmt --all -- --check,cargo clippy --workspace --all-targets -- -D warnings, andcargo test --workspace, or explained exactly why a command was not rundocs/storage-key-invariants.md; any storage layout change includes a migration/backward-compatibility notedocs/contract-event-conventions.md, or documented the breaking change and versioning plan