Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends mtd-cli to support sending multiple user-supplied extra HTTP headers (up to 10) via the MTD_CLI_HDRS environment variable, instead of only supporting a single header.
Changes:
- Add parsing of
MTD_CLI_HDRSinto an array of up to 10 headers (using\as the separator) and pass that array intolibmtdacviamtd_cfg.extra_hdrs. - Improve cleanup/exit flow in
main()by avoiding earlyexit()on init failure and freeing allocated header storage on exit paths. - Update README documentation to describe how to provide multiple headers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/mtd-cli.c |
Adds support for up to 10 extra HTTP headers via MTD_CLI_HDRS and wires them into the mtd_cfg passed to mtd_init(). |
README.rst |
Updates environment variable documentation to explain multiple-header syntax and provides an additional example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Previously you could pass a single extra HTTP header which was good enough to pass a Gov-Test-Scenario header. However I noticed an endpoint actually allowing another header to be set. 10 headers should be plenty (for now). Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously you could pass a single extra HTTP header which was good enough to pass a Gov-Test-Scenario header. However I noticed an endpoint actually allowing another header to be set.
10 headers should be plenty (for now).