Skip to content

fix #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abulgit wants to merge 1 commit into from
Closed

fix #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion compiler/src/dmd/funcsem.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,10 +826,15 @@ void funcDeclarationSemantic(Scope* sc, FuncDeclaration funcdecl)
if (auto id = parent.isInterfaceDeclaration())
{
funcdecl.storage_class |= STC.abstract_;
if (funcdecl.isCtorDeclaration() || funcdecl.isPostBlitDeclaration() || funcdecl.isDtorDeclaration() || funcdecl.isInvariantDeclaration() || funcdecl.isNewDeclaration() || funcdecl.isDelete())
const isSpecialFunc = funcdecl.isCtorDeclaration() || funcdecl.isPostBlitDeclaration() || funcdecl.isDtorDeclaration() || funcdecl.isInvariantDeclaration() || funcdecl.isNewDeclaration() || funcdecl.isDelete();
if (isSpecialFunc)
.error(funcdecl.loc, "%s `%s` constructors, destructors, postblits, invariants, new and delete functions are not allowed in interface `%s`", funcdecl.kind, funcdecl.toPrettyChars, id.toErrMsg());
if (funcdecl.fbody && funcdecl.isVirtual())
.error(funcdecl.loc, "%s `%s` function body only allowed in `final` functions in interface `%s`", funcdecl.kind, funcdecl.toPrettyChars, id.toErrMsg());
// A final interface function has no vtable slot, so no class can supply its
// body. Only a foreign linkage can, from the other side.
if (!isSpecialFunc && !funcdecl.fbody && !funcdecl.isStatic() && funcdecl.isFinalFunc() && funcdecl.resolvedLinkage() == LINK.d)
.error(funcdecl.loc, "%s `%s` `final` function requires a body in interface `%s`", funcdecl.kind, funcdecl.toPrettyChars, id.toErrMsg());
}

if (UnionDeclaration ud = parent.isUnionDeclaration())
Expand Down
31 changes: 31 additions & 0 deletions compiler/test/fail_compilation/issue23470.d
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
/*
TEST_OUTPUT:
---
fail_compilation/issue23470.d(14): Error: function `issue23470.A.foo` `final` function requires a body in interface `A`
---
*/

// https://github.com/dlang/dmd/issues/23470

final:

interface A
{
void foo();
}

class B : A
{
void foo() { }
}

// exempt, the definition can come from the other language
extern (C++) interface C
{
void bar();
}

extern (C) interface D
{
void baz();
}
Loading