Repository navigation
Conversation
…a werewolf/vampire lord
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI SLOPPED PR Respawn the puppet for any non-playable race, not just the vanilla werewolf / Vampire Lord
Problem
PlayerService::RunBeastFormDetectiononly firesBeastFormChangeEvent(and so theRequestRespawnwith the serialized appearance) when the local player's race is0xCDD84(WerewolfBeastRace) or0x200283A(DLC1VampireBeastRace).Mods that transform the player with
SetRaceinto their own beast races are never detected. Enderal's Theriantrophist wolf form (_00E_Theriantrophist_PlayerWerewolfRace, set by_00E_Theriantrophist_WolfFormSC) is one: the behavior graph is synced (the client logsBehaviorVar::Patch ... Werewolf signature iState_WerewolfBeastDefaultfor formID 14), but the puppet is never respawned with the new race. Other players see the human body stretched over the werewolf skeleton and animations, and it stays human-shaped after the form ends.Change
isBeastRacekeeps the two vanilla IDs and additionally treats any non-playable race as a beast race, so entering and leaving such a race triggers the existing respawn path.TESRacegains theRACE_DATAflags field (0x108,kPlayable = 1 << 0) with astatic_asserton the offset. The layout matches CommonLibSSE-NG (RACE_DATA data; // 0E8,flags; // 20).No protocol, server or behavior-graph changes; the vanilla werewolf / Vampire Lord path is unchanged.
Testing