Repository navigation
Conversation
A remote player's Detect Life replayed on every client and synced to nearby players, so everyone saw living targets. It now only applies on the caster's own client. With PvP on, the caster's Detect Life also shows other players, which HookAddTarget used to refuse. Needs an in-game test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018fvQxQEu7yvi9eRZyKsEur
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Eric · project thread
Part of tiltedphoques#938 ("Detect life doesn't detect players").
What
HookAddTargetused to refuse.AddTargetData::ShouldSync. NewEffectItem::IsDetectLifeEffect()checks the archetype.Independent of the other PvP PRs; applies cleanly on
devalone.Verified vs assumed
Testing
Generated by Claude Code