Skip to content

Show other players with Detect Life and keep it to the caster - #32

Open
absol89 wants to merge 1 commit into
devfrom
feat/pvp-detect-life
Open

absol89 wants to merge 1 commit into
devfrom
feat/pvp-detect-life

Conversation

@absol89

@absol89 absol89 commented Nov 5, 2026 •

Copy link
Copy Markdown
Owner

Requested by Eric · project thread

Part of tiltedphoques#938 ("Detect life doesn't detect players").

What

  • A remote player's Detect Life used to replay on every client and sync to nearby players, so everyone saw living targets. Now it only applies on the caster's own client, whether PvP is on or off. Players who don't have the mod that adds the spell aren't affected.
  • With PvP on, your own Detect Life now shows other players, which HookAddTarget used to refuse.
  • Detect-life effects are excluded from AddTargetData::ShouldSync. New EffectItem::IsDetectLifeEffect() checks the archetype.

Independent of the other PvP PRs; applies cleanly on dev alone.

Verified vs assumed

  • Assumed: the spell uses the Detect Life archetype. A modded variant built another way won't be caught.
  • Not tested in game yet.

Testing

  • Builds with the client and server.
  • Still needed, two clients: A casts Detect Life and sees B (PvP on) and NPCs; B doesn't see the shader on anything; same with PvP off (A sees NPCs only, B sees nothing).

Generated by Claude Code

image

A remote player's Detect Life replayed on every client and synced to nearby players, so everyone saw living targets. It now only applies on the caster's own client. With PvP on, the caster's Detect Life also shows other players, which HookAddTarget used to refuse. Needs an in-game test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018fvQxQEu7yvi9eRZyKsEur
@absol89 absol89 self-assigned this Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant