Skip to content

Rust SDK: All tests passing (302/302 unit, 138/138 cross-SDK) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joalves wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Rust SDK: All tests passing (302/302 unit, 138/138 cross-SDK) #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
d9de45f
docs: add Axum, Actix, Rocket examples and async patterns to Rust SDK
joalves Jan 30, 2026
1271782
fix: correct method signatures to match Rust SDK implementation
joalves Jan 30, 2026
5dac9d7
test: add canonical test parity (130 → 302 tests)
joalves Feb 6, 2026
fd3e347
fix: resolve cross-SDK test failures for 100% pass rate
joalves Feb 21, 2026
33f9e06
docs: restructure README to match standard SDK documentation structure
joalves Feb 24, 2026
f06b9eb
fix: wire ContextOptions into Context and replace eprintln with log c…
joalves Feb 26, 2026
a39309d
fix: remove finalized guard from set_override to match JS SDK behavior
joalves Mar 15, 2026
cfea56f
feat(rust): add ready_error returning Option<&String> from failed con…
joalves Mar 15, 2026
914ece2
feat: add close/is_closed/is_closing aliases and standardize error me…
joalves Mar 15, 2026
53bc8ef
test(rust): replace refresh_with bypass with mock fetcher + public re…
joalves Mar 15, 2026
d7533ec
fix: use selective cache invalidation in refresh_with instead of clea…
joalves Mar 16, 2026
4d33f2a
feat: cross-SDK consistency fixes — all 201 scenarios passing
joalves Mar 17, 2026
ef5463b
refactor: rename ContextEventHandler to ContextPublisher
joalves Mar 18, 2026
e3ddea3
fix: address coderabbit review issues
joalves Mar 18, 2026
9f77bbe
feat(jsonexpr): make IN haystack-first and add CONTAINS alias
joalves Jun 15, 2026
bfe2086
ci: fix Rust workflow action ref and clear clippy/fmt lints
joalves Jun 16, 2026
e664c49
ci: drop unrealistic Rust 1.70.0 from test matrix
joalves Jun 16, 2026
8e523e2
fix(jsonexpr): eq(null, null) returns null (canonical null-operand ha…
joalves Jun 16, 2026
860b1d5
test: add canonical astral/multibyte hashUnit regression test
joalves Jun 17, 2026
483eb32
test: add hermetic local-HTTP integration test for real fetch/publish
joalves Jun 25, 2026
f06ada8
fix: send full canonical header set on publish (PUT /context)
joalves Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
rust: [stable, 1.70.0]
rust: [stable]

steps:
- uses: actions/checkout@v4

- name: Install Rust
uses: dtolnay/rust-action@stable
uses: dtolnay/rust-toolchain@master

@coderabbitai coderabbitai Bot Jun 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Pin dtolnay/rust-toolchain to specific version or commit SHA across all workflow jobs. All five action references use @master, which is a moving target that can introduce breaking changes or security vulnerabilities without notice. Pin to an immutable reference for stability and supply-chain security.

  • .github/workflows/ci.yml#L26-L26: pin the action reference in the test job to a specific version tag (e.g., @1.0.0) or commit SHA.
  • .github/workflows/ci.yml#L54-L54: pin the action reference in the lint job to a specific version tag or commit SHA.
  • .github/workflows/ci.yml#L72-L72: pin the action reference in the docs job to a specific version tag or commit SHA.
  • .github/workflows/publish.yml#L19-L19: pin the action reference in the test job to a specific version tag or commit SHA.
  • .github/workflows/publish.yml#L34-L34: pin the action reference in the publish job to a specific version tag or commit SHA.
🧰 Tools
🪛 zizmor (1.25.2)

[error] 26-26: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy)

(unpinned-uses)

📍 Affects 2 files
  • .github/workflows/ci.yml#L26-L26 (this comment)
  • .github/workflows/ci.yml#L54-L54
  • .github/workflows/ci.yml#L72-L72
  • .github/workflows/publish.yml#L19-L19
  • .github/workflows/publish.yml#L34-L34
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci.yml at line 26, Replace the moving target reference
`@master` with an immutable pinned version across all five
dtolnay/rust-toolchain action uses to prevent supply-chain security
vulnerabilities and ensure build stability. In .github/workflows/ci.yml at lines
26, 54, and 72, change each `uses: dtolnay/rust-toolchain@master` to use a
specific version tag (e.g., `@1.0.0`) or commit SHA. In
.github/workflows/publish.yml at lines 19 and 34, apply the same pinning change
to the dtolnay/rust-toolchain action references. Use the same pinned version
across all five locations for consistency.

Source: MCP tools

with:
toolchain: ${{ matrix.rust }}

Expand Down Expand Up @@ -51,7 +51,7 @@ jobs:
- uses: actions/checkout@v4

- name: Install Rust
uses: dtolnay/rust-action@stable
uses: dtolnay/rust-toolchain@master
with:
toolchain: stable
components: rustfmt, clippy
Expand All @@ -69,7 +69,7 @@ jobs:
- uses: actions/checkout@v4

- name: Install Rust
uses: dtolnay/rust-action@stable
uses: dtolnay/rust-toolchain@master
with:
toolchain: stable

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- uses: actions/checkout@v4

- name: Install Rust
uses: dtolnay/rust-action@stable
uses: dtolnay/rust-toolchain@master
with:
toolchain: stable

Expand All @@ -31,7 +31,7 @@ jobs:
- uses: actions/checkout@v4

- name: Install Rust
uses: dtolnay/rust-action@stable
uses: dtolnay/rust-toolchain@master
with:
toolchain: stable

Expand Down
8 changes: 8 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ thiserror = "1.0"
md-5 = "0.10"
base64 = "0.22"
reqwest = { version = "0.12", features = ["json"] }
tokio = { version = "1.0", features = ["rt-multi-thread"] }
tokio = { version = "1.0", features = ["rt-multi-thread", "time"] }
urlencoding = "2.1"
log = "0.4"

[dev-dependencies]
tokio = { version = "1.0", features = ["full", "test-util"] }
Loading
Loading