Skip to content

Dont expose extract_probability as C API parameter#169

Merged
absadiki merged 1 commit into
absadiki:mainfrom
RomanValov:main
May 30, 2026
Merged

Dont expose extract_probability as C API parameter#169
absadiki merged 1 commit into
absadiki:mainfrom
RomanValov:main

Conversation

@RomanValov

@RomanValov RomanValov commented May 21, 2026

Copy link
Copy Markdown
Contributor

Presence of extract_probability parameter on PARAMS_SCHEMA dict causes a confusion
because docs say PARAMS_SCHEMA parameters should be recognized on Model.__init__
and passed to underlying whisper.cpp library.
But attempts to pass extract_probability to Model.__init__ cause segfaults.
Indeed extract_probability handled purely on python side.

CC @wooii

@absadiki

Copy link
Copy Markdown
Owner

Good catch @RomanValov. You're right, extract_probability is handled entirely on the Python side, so having it inside PARAMS_SCHEMA is misleading and can definitely cause confusion given the current docs/behavior.

I just ran CI, and it's currently failing. There also appear to be some merge conflicts since another PR was merged into main recently.

Could you please rebase onto the latest main, resolve any conflicts, and fix the syntax error?

Thanks!

@RomanValov RomanValov reopened this May 27, 2026
@RomanValov

Copy link
Copy Markdown
Contributor Author

I have rebased it and fixed the syntax. Should be passing tests now

@absadiki absadiki merged commit 294e1e1 into absadiki:main May 30, 2026
48 checks passed
@absadiki

Copy link
Copy Markdown
Owner

Sounds Good!
Thanks @RomanValov for the contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants