Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions src/univers/gentoo.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,3 +181,38 @@ def vercmp(ver1, ver2):
# Our versions had different strings but ended up being equal.
# The revision holds the final difference.
return cmp(rev1, rev2)


def bump(ver):
"""
Return a new version string where the next to the last revision number
is one greater (e.g., 5.3.1 => 5.4) i.e., incrementing this GentooVersion
last numeric segment.
"""
if not ver:
return None

ver = remove_spaces(ver)
if ":" in ver:
ver = ver.split(":")[0]
if ver.endswith("*"):
ver = ver[:-1]

version, _ = parse_version_and_revision(ver)

base = version.split("_")[0]
segments = base.split(".")

if segments and segments[-1] and segments[-1][-1].isalpha():
segments[-1] = segments[-1][:-1]

int_segments = [int(s) for s in segments if s]

if not int_segments:
return None

if len(int_segments) > 1:
int_segments.pop()

int_segments[-1] += 1
return ".".join(str(s) for s in int_segments)
4 changes: 4 additions & 0 deletions src/univers/versions.py
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,10 @@ def __gt__(self, other):
return NotImplemented
return gentoo.vercmp(self.value, other.value) == 1

def bump(self):
bumped = gentoo.bump(self.value)
return self.__class__(bumped) if bumped else None


class AlpineLinuxVersion(GentooVersion):
@classmethod
Expand Down
19 changes: 19 additions & 0 deletions tests/test_gentoo.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,22 @@ def comparison(self):
def test_gentoo_vers_cmp(test_case):
avc = GentooVersionComp.from_data(data=test_case)
avc.assert_result()


def test_gentoo_bump():
assert GentooVersion("2.23.3").bump() == GentooVersion("2.24")
assert GentooVersion("2.24.3").bump() == GentooVersion("2.25")
assert GentooVersion("2.25.4").bump() == GentooVersion("2.26")
assert GentooVersion("2.26.2").bump() == GentooVersion("2.27")
assert GentooVersion("1.0.5").bump() == GentooVersion("1.1")
assert GentooVersion("5.3").bump() == GentooVersion("6")
assert GentooVersion("5").bump() == GentooVersion("6")
assert GentooVersion("1.3.8b").bump() == GentooVersion("1.4")
assert GentooVersion("9.9_p2").bump() == GentooVersion("10")
assert GentooVersion("0.13.4-r2").bump() == GentooVersion("0.14")
assert GentooVersion("2.23.3-r1").bump() == GentooVersion("2.24")
# Handling slots and wildcards during bump
from univers import gentoo

assert gentoo.bump("3.24.48:3") == "3.25"
assert gentoo.bump("1.3*") == "2"