Repository navigation
Add rules for GPL-2.0 notices with the old FSF postal address - #5498
Open
Ashutosh-Panda2004 wants to merge 1 commit into
Open
Ashutosh-Panda2004 wants to merge 1 commit into
Ashutosh-Panda2004 wants to merge 1 commit into
Conversation
The GPL-2.0-only notice used by the Linux kernel ray_cs.c driver ends with the old Free Software Foundation postal address instead of the gnu.org licenses URL covered by gpl-2.0_1226, so it is detected as another GPL variant. Add gpl-2.0_1487 for the version 2 only wording and gpl-2.0-plus_1156 for the version 2 or later wording, with data-driven tests for both. Signed-off-by: Ashutosh Panda <ashutoshpanda.india@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GPL-2.0-only notice used by the Linux kernel ray_cs.c driver is not detected as gpl-2.0. It is reported as gpl-3.0-plus on 32.5.0 (see #5039), and on current develop it comes out as gpl-1.0-plus instead. Either way the detection is wrong.
The existing rule gpl-2.0_1226 covers this notice only with the modern ending that points to https://www.gnu.org/licenses/. The ray_cs.c variant ends with the old Free Software Foundation postal address (59 Temple Place, Boston) instead, so no rule covers it and a fuzzy 3-seq match against a full GPL license text wins.
This adds two rules for the notice variants that end with the old postal address, following the same style as gpl-2.0_1226:
Both rules have data-driven tests in tests/licensedcode/data/datadriven/lic1 (ray_cs_gpl-2.0.c and ray_cs_gpl-2.0-plus.c).
Test report:
Fixes #5039