Skip to content

Fix crash in ConanFileHandler and support list attributes (fixes #5495) - #5496

Open
muskan-creates352 wants to merge 1 commit into
aboutcode-org:developfrom
muskan-creates352:fix-conan-parser-issues-5495
Open

muskan-creates352 wants to merge 1 commit into
aboutcode-org:developfrom
muskan-creates352:fix-conan-parser-issues-5495

Conversation

@muskan-creates352

Copy link
Copy Markdown

Summary of Changes

Fixes #5495

This PR addresses multiple issues in src/packagedcode/conan.py:

  1. Avoid crash on module-qualified base or non-ConanFile classes:

    • In ConanFileHandler._parse, search node.bases for any base that is either ast.Name(id="ConanFile") or ast.Attribute(attr="ConanFile"), adding support for conan.ConanFile (standard in Conan 2.0).
    • If no class definition inherits from ConanFile (e.g., empty file, non-recipe Python script), safely return None instead of calling parser.visit(None) which previously raised AttributeError: 'NoneType' object has no attribute '_fields'.
  2. Prevent yielding None:

    • In ConanFileHandler.parse, only yield when _parse() returns a valid PackageData object instead of unconditionally yielding [None].
  3. Support ast.List for list-based attributes:

    • In ConanFileParser.visit_Assign, allow (ast.Tuple, ast.List) so that requires = ["..."], topics = ["..."], and license = ["..."] are properly extracted rather than silently dropped.
  4. Handle delimiterless requires entries:

    • In get_dependencies, handle requirement entries that do not contain / (e.g., requires = ["package_name"]), preventing ValueError: not enough values to unpack.
  5. Unit Tests:

    • Added unit tests in tests/packagedcode/test_conan.py covering module-qualified bases (conan.ConanFile), non-ConanFile/empty files, list-based dependencies, topics, license, and delimiterless requirements.

Sign-off

Signed-off-by: Muskan Kumari er.muskan09@gmail.com

…tcode-org#5495)

- In ConanFileHandler._parse, safely check for any base matching ConanFile, supporting module-qualified bases like conan.ConanFile (Conan 2.0).

- Safely handle empty files and files without a ConanFile class, avoiding AttributeError: 'NoneType' object has no attribute '_fields'.

- Do not yield None from ConanFileHandler.parse.

- Support ast.List for requires, topics, and license attributes in ConanFileParser.visit_Assign.

- Handle requires entries without a slash delimiter in get_dependencies.

- Add unit tests for qualified base, non-ConanFile files, list dependencies, and delimiterless requirements.

Signed-off-by: Muskan Kumari <er.muskan09@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] ConanFileHandler crashes on conan.ConanFile or non-ConanFile classes and drops list-based dependencies, topics, and license

1 participant