Repository navigation
Vendor the utilities from abap-util, drop src/99/01 - #50
Merged
Merged
Conversation
sql-console no longer uses anything from abap2UI5's frozen src/99/01: - z2ui5_sql_cl_context: renamed copy of abap-util's zabaputil_cl_util_context, trimmed to the 16 members used here plus their helpers (23 of 315 methods); replaces z2ui5_cl_util - z2ui5_sql_cl_db + table z2ui5_sql_db: renamed copies of zabaputil_cl_util_db / zabaputil_t_91; replace z2ui5_cl_util_db and z2ui5_t_91 for the query history and the draft - z2ui5_sql_cx_error: renamed copy of zabaputil_cx_util_error; replaces z2ui5_cx_util_error (21 places) The history and the draft start empty after the update: they were stored in z2ui5_t_91, which is not migrated (the rows stay there). z2ui5_cl_ajson and z2ui5_cl_srt_* (xml_srtti_*) remain the core's own classes, which are always installed with abap2UI5. The copy of zabaputil_cl_util_db is excluded from select_single_full_key and select_add_order_by instead of rewritten, so it stays diffable against the master. The two stale non-released-api baseline entries are gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014YZFmFss2kJkNtJWUEfNme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
abap2UI5's
src/99/01(z2ui5_cl_util*,z2ui5_cx_util_error,z2ui5_t_91) is kept for compatibility only. This moves sql-console onto renamed copies from abap-util, the pattern popups already uses.Changes
z2ui5_sql_cl_contextzabaputil_cl_util_context, trimmed to the 16 members used here + helpers (23 of 315 methods)z2ui5_cl_utilz2ui5_sql_cl_dbzabaputil_cl_util_db, as-isz2ui5_cl_util_dbz2ui5_sql_dbzabaputil_t_91, as-isz2ui5_t_91z2ui5_sql_cx_errorzabaputil_cx_util_error, as-isz2ui5_cx_util_error(21×)z2ui5_t_91and are not migrated (decided: start fresh; the rows stay inz2ui5_t_91).z2ui5_cl_ajsonandz2ui5_cl_srt_*(forxml_srtti_*) stay the core's own classes, always installed with abap2UI5.zabap2ui5_sql_db) stays within the 16-character limit.select_single_full_key/select_add_order_byinabaplint.jsoncinstead of rewritten, so it stays diffable against the master.non-released-api … src/99/01entries removed fromabap2ui5lint-baseline.json.Verification
npm run check: abaplint Standard + Cloud 0 issues, abap2ui5lint no findings, rename check 0 issuesGenerated by Claude Code