Skip to content

fix(itk): Fixing ITK issues - #1344

Merged
kabir merged 2 commits into
a2aproject:mainfrom
ehsavoie:itk_fixes
Nov 20, 2026
Merged

kabir merged 2 commits into
a2aproject:mainfrom
ehsavoie:itk_fixes

Conversation

@ehsavoie

Copy link
Copy Markdown
Collaborator

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests pass
  • Appropriate READMEs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ehsavoie
ehsavoie requested a review from kabir November 17, 2026 10:13
@jmesnil

jmesnil commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

a2a-java runs the TCK based on its https://github.com/a2aproject/a2a-tck/releases/tag/1.0.0.alpha3 tag that corresponds to A2A 1.0.0 spec.

The application/a2a+json content-type was introduced in https://github.com/a2aproject/A2A/releases/tag/v1.0.1.

I've recently updated the TCK main branch to comply with A2A 1.0.1 spec and opened #1301 to update a2a-java CI.
@kabir pushed back against it in #1298 (comment) so I closed #1301 without merging it.

@ehsavoie
ehsavoie force-pushed the itk_fixes branch 3 times, most recently from 3635638 to f621a11 Compare November 19, 2026 07:57
updateResult = updateTaskStore(taskId, event, isReplicated, initialMessage);
if (event instanceof Task || event instanceof TaskStatusUpdateEvent
|| event instanceof TaskArtifactUpdateEvent || event instanceof A2AError) {
initialMessages.remove(taskId);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [P2] Preserve the opening message when a status event creates the task — MainEventBusProcessor.java (server-common/src/main/java/org/a2aproject/sdk/server/events/MainEventBusProcessor.java:264)
    This removes the saved message after a status or artifact update. TaskManager adds that message to history only when saving a Task event; a common first event such as startWork() creates the task through the status-update path instead. The message is then lost from task history.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reported issue does not reproduce in the current code. When a status or artifact update creates a task, TaskManager.createTask() includes the opening message in its history before the processor removes the saved message.

Comment thread itk/summarize_results.sh Outdated
reports=("$@")
else
shopt -s nullglob
reports=("$script_dir"/acts_results_*.json)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [P2] Match the ACTS report filename in the default glob — summarize_results.sh (itk/summarize_results.sh:39)
    The no-argument command searches for acts_results_.json, while the script’s example uses acts-report-.json. After an ACTS run, the documented summary command may find no reports and exit with an error.

Validate message input modes across transports and correct REST and JSON-RPC
wire formats, streaming responses, and push notification errors. Preserve
opening messages in task history and distribute persisted task snapshots.

Add a local ITK and ACTS launcher with Podman support and a results summary,
along with regression coverage for server and transport behavior.

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
@kabir
kabir merged commit 1fc0c3d into a2aproject:main Nov 20, 2026
15 checks passed
Shay-Deng added a commit to Shay-Deng/a2a-java that referenced this pull request Nov 20, 2026
a2aproject#1344 accepted extra top-level SendMessage parameters through
ProtoJsonUtils.retainKnownFields, but kept nested objects and other
methods strict. Section 5.7 and TCK DM-SERIAL-005 cover unrecognized
fields inside the message as well, so SendMessage and
SendStreamingMessage now use the same descriptor-based removal as every
other method, and retainKnownFields is removed.

A SendMessage without a message is still rejected. The a2aproject#1344 tests that
expected nested extras and an extra GetTask parameter to be rejected now
expect them to be ignored.

The enum tests no longer check the error text, only that the value is
rejected, so they don't depend on how the message is worded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants