Repository navigation
Conversation
ehsavoie
requested changes
Nov 18, 2026
ehsavoie
left a comment
Collaborator
There was a problem hiding this comment.
I tend to disagree with the original as default in case of null. We shouldn't allow for a null payload.
Also I'm not a big fan of var :)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v0.3 REST transport invokes interceptors, but constructs task and push-config URLs from the original parameters. A request whose intercepted task ID was changed still went to the original task.
Build those paths from the returned protobuf builder or message; reject null payloads for request-bearing operations before sending HTTP. Forward pagination fields set on an intercepted list request. The list request's
parentis nowtasks/{id}, matching the proto rather than including the collection suffix.The existing list API returns only the current list, not a continuation token; interceptors setting pagination should account for that limitation. This PR addresses interceptor-derived URL fields; it does not change the existing create-config HTTP body representation or add general resource-ID path encoding.
Validation
mvn -q -pl compat-0.3/client/transport/rest -am clean test(735 reactor tests passed).git diff --check.