add tool-writer mode to marketplace#604
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a new marketplace mode ChangesTool Writer Mode
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
src/assets/marketplace/modes.yml (1)
4220-4221: ⚡ Quick winRestrict
editscope to tool-authoring paths (least privilege).For a tool-authoring mode, unrestricted
editis broader than needed. Narrowing edits to tool-related paths reduces accidental/destructive writes.Suggested refactor
groups: - read - - edit + - - edit + - fileRegex: (\.roo/tools/.*\.(ts|js|json)$|\.roo/tools/\.env(\..+)?$) + description: Tool source/config files under .roo/tools - command🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/assets/marketplace/modes.yml` around lines 4220 - 4221, The current mode in modes.yml grants a broad "edit" scope (the literal token edit under the mode whose entry shows "source: project"), which is too permissive for tool-authoring; replace that single "edit" permission with a least-privilege set of targeted edit path rules (e.g., restrict to globs like tools/**, tooling/**, tool-config/** or the project's canonical tool-authoring paths) so only tool-related files can be modified, updating the mode's permissions entry (the place that currently contains "edit" and "source: project") to enumerate those specific path patterns instead of the unrestricted "edit".
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/assets/marketplace/modes.yml`:
- Around line 4218-4221: The marketplace mode grants the tool-writer only
read/edit permissions; add the missing command permission so the documented
workflows can run npm/test steps. Update the roles block for the tool-writer
entry (the groups: - read - edit stanza in modes.yml for the tool-writer mode)
to include command (e.g., groups: - read - edit - command) in the same entries
that describe the workflows, and ensure every occurrence that documents running
commands (the mode definitions that instruct npm/test) gets the same addition so
the mode can execute commands as intended.
- Around line 4214-4216: Update the mode description so the scope wording
consistently mentions both project and global tool locations instead of only
`.roo/tools`; change the `roleDefinition`/`whenToUse` text that currently
references `.roo/tools` alone to explicitly state both `.roo/tools` (project)
and `~/.roo/tools` (global) and clarify when to use each (e.g., local project
development vs. shared/global tools), ensuring the same phrasing is used
wherever the mode documents tool locations to avoid conflicting guidance.
---
Nitpick comments:
In `@src/assets/marketplace/modes.yml`:
- Around line 4220-4221: The current mode in modes.yml grants a broad "edit"
scope (the literal token edit under the mode whose entry shows "source:
project"), which is too permissive for tool-authoring; replace that single
"edit" permission with a least-privilege set of targeted edit path rules (e.g.,
restrict to globs like tools/**, tooling/**, tool-config/** or the project's
canonical tool-authoring paths) so only tool-related files can be modified,
updating the mode's permissions entry (the place that currently contains "edit"
and "source: project") to enumerate those specific path patterns instead of the
unrestricted "edit".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: bd745a15-63cc-47b0-8ec7-fcc24cba6399
📒 Files selected for processing (1)
src/assets/marketplace/modes.yml
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Related GitHub Issue
Closes: #603
Description
Adds tool-writer mode to the marketplace. Writing tools is a bit finicky especially since the only way to test them is by asking Zoo to run its tool. This mode could have a dump of the documentation from https://github.com/Zoo-Code-Org/Zoo-Code-Docs/blob/main/docs/features/experimental/custom-tools.md and some additional examples.
Test Procedure
Pre-Submission Checklist
Documentation Updates
Does this PR necessitate updates to user-facing documentation?
Summary by CodeRabbit
New Features
Documentation