Repository navigation
feat(tools): onParameterParseFailure teardown boundary (split 4/6 of #1066) #1931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
easonLiangWorldedtech
wants to merge
11
commits into
Zoo-Code-Org:main
Choose a base branch
from
easonLiangWorldedtech:p1066/u3-parse-failure-boundary
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7730515
fix(write-to-file): close the parse-failure and post-commit teardown …
easonLiangWorldedtech b1161c5
fix(tools): close a dirty diff tab before unlinking, and stop saveCha…
easonLiangWorldedtech a7a5d92
fix(editor): report a restored-buffer save that did not land before c…
easonLiangWorldedtech e7e2188
fix(editor): scope the rollback save failure to the attempt that hit it
easonLiangWorldedtech 45090bc
test(write-to-file): assert the failed report by identity so the merg…
easonLiangWorldedtech e42a64d
test(tools): linearise U3 onto main tip and move its own tests out of…
easonLiangWorldedtech 047c3f8
test(tools): pin the revert-before-reset order on the parse-failure t…
c7c9f7b
fix(editor): scope the write result report to the save that produced it
a58177a
test(tools): give the early-return row its own pushToolResult callback
9212b8e
test(editor): sweep every matching tab in the rollback teardown
16af49d
Merge branch 'main' into p1066/u3-parse-failure-boundary
easonLiangWorldedtech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.