Skip to content

test(api): prove inherited caller cancellation for baseten, fireworks and sambanova #2501

Open

Description

@easonLiangWorldedtech

Scope: verification only, no new wiring

baseten, fireworks and sambaNova are thin shells over the shared compatible base - at main 75a93a9d9acc each file is ~20 lines with no method overrides and no abort handling of its own:

src/api/providers/baseten.ts:6:  export class BasetenHandler extends BaseOpenAiCompatibleProvider<BasetenModelId> {
src/api/providers/fireworks.ts:7: export class FireworksHandler extends BaseOpenAiCompatibleProvider<FireworksModelId> {
src/api/providers/sambanova.ts:7: export class SambaNovaHandler extends BaseOpenAiCompatibleProvider<SambaNovaModelId> {

git grep -c -F abortSignal returns nothing for all three: they receive caller cancellation and the request timeout entirely through base-openai-compatible-provider.ts (the RequestConfigBuilder + throwIfAborted path that #1311 adds). They therefore need no provider-specific patch PR, and they are not part of the seven hand-written bridges listed in #2486.

Acceptance criteria (after #1311 merges)

  1. Re-run baseten.spec.ts, fireworks.spec.ts, sambanova.spec.ts together with base-openai-compatible-provider.spec.ts and base-openai-compatible-provider-timeout.spec.ts against the merged base, and record the pass/fail count per provider in this issue.
  2. Add one small regression spec per provider pinning the inherited contract rather than the base contract:
    • a pre-aborted caller rejects with name === "AbortError" before any HTTP request is issued;
    • a cancel during the request rejects with AbortError and is not re-wrapped with the provider's own error prefix;
    • a timeout expiry surfaces with the verdict that refactor(api): move hand-written abort bridges to the shared helper #2486 U0b settles for this family (TimeoutError from createTimeoutError(providerName, phase) vs the gateway family's AbortError) - the specs must not drift per provider.
  3. Confirm no provider-local AbortController / addEventListener("abort") appears in the three files, so refactor(api): move hand-written abort bridges to the shared helper #2486 U7 can keep the hygiene selectors strict.

Budget

Three focused specs in one PR, roughly 120 a+d total; no production file changes expected unless a criterion above fails.

Dependencies

Sibling families that inherit rather than patch, for the same record: deepseek / mimo / moonshot / kimi-code via OpenAiHandler (covered by #1311 specs), github-copilot via VsCodeLmHandler (#2486 U6), vertex via GeminiHandler.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions