Repository navigation
Conversation
Filter the cause and text of POST /monitors/{id}/alarm to letters, digits,
spaces and plain punctuation, as ZoneMinder's API v2 does
(MonitorsController::alarmCause): both end up in Events.Cause and
Events.Notes. An empty or unusable cause is recorded as "API", as a missing
one is. Write score, cause and texts to shared memory before the trigger
state, as Monitor::ForceAlarmOn does.
fixes ZoneMinder#254
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
All contributors have signed the CLA. ✅ |
Member
|
@nabbi need to CLA under zm |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
… as v2 does The 31- and 255-byte limits were checked on the request as sent, so a cause that fits once its quotes and control characters are dropped got a 400. API v2's alarmCause filters first and then cuts to 31 bytes on a character boundary. Do the same, and cut the text to the 255-byte shm field the same way. The request still refuses a cause over 1024 bytes or a text over 4096, so an oversized body is a 400 rather than work for the filter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impact: low (a forced alarm's cause and text were stored as sent; an empty cause recorded "Continuous")
TL;DR
punctuation); empty or unusable ones record the defaults; shared memory gets the texts before the trigger state.
2 files, +98/-6
their 400 unchanged
Details: see Forced alarm: cause and text are stored as sent, unlike API v2 (and an empty cause records "Continuous") #254.
Tested as
2939e479e;35a1d8d19is the same tree withfixes #254in the message.fixes #254
🤖 Generated with Claude Code