Repository navigation
ci(release): open the release PR only after the tag job - #60
Merged
Merged
Conversation
On the push that merges a release PR, the release-PR job ran beside the tag job. When it read the releases first, it found none for the new version, read the whole history as unreleased, and opened a release PR that listed changes already shipped. It now waits for the tag job.
StefanoGuerrini
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release-PR job now runs after the tag job. On the push that merges a release PR, the two jobs ran side by side. When the release-PR job read the releases first, it found none for the new version and opened a release PR that listed changes already shipped.
What the task asked for
Stop release-please from proposing releases that repeat shipped changes.
How the check confirmed it
actionlintpasses onrelease.yml. In one release run, the release-PR job loggedExpected 1 releases, only found 0. The tag job created that release 39 seconds later. The release-PR job had already opened a release PR from the whole history.Encoded by: none.How to try it
Nothing to run before merge. After the next release PR merges, the run shows
Open or update the release PRstarting afterTag, release and publish.Provenance
On a push that merges no release PR, GitHub skips the
releasejob.needs.release.resultis thenskipped, and the release-PR job runs as before. A failedreleasejob skips it, so a re-run handles both jobs. Ifbuildfails, GitHub skipsreleaseinstead, and the release-PR job runs. It then finds the merged release PR still untagged and opens nothing.Review
Human must verify:
releaseenvironment needs approval, the release-PR job waits for that approval too.Deviations
None.
Record owed
None.