Pin nanoid to a patched 3.x - #168
Merged
Merged
Conversation
New high advisory: nanoid's custom generators loop indefinitely when size is zero. The installed 3.3.16 comes in only through postcss, which is not a place this project passes a user-controlled size to — but postcss runs on every build and the fix is a version floor, so there is no reason to carry it. Pinned with a caret rather than the >= used by some of the neighbouring entries. ">=3.3.18" resolves to nanoid 6.0.1, three majors up and ESM-only, which postcss cannot require — it asks for ^3.3.16. "^3.3.18" keeps the bump inside 3.x. pnpm why now reports a single nanoid@3.3.18 under postcss. typecheck and a six-locale build pass, which exercises postcss throughout. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
YurMil
added a commit
that referenced
this pull request
Aug 17, 2026
No dependabot alerts remain open. What is left in the runbook is now exactly the work that needs Supabase project access, which is worth saying explicitly so the next reader does not re-audit the closed items. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the new high advisory (#172): nanoid's custom generators loop indefinitely when
sizeis zero.nanoid@3.3.16reaches the tree only throughpostcss, which is not somewhere this project hands a user-controlledsizeto. But postcss runs on every build, the fix is a version floor, and the existingpnpm.overridesblock is already the established way this repo handles transitive advisories — so there is no reason to carry it.One thing worth noting
Some neighbouring entries use
>=. That does not work here:Three majors up and ESM-only, while postcss asks for
^3.3.16and requires it as CommonJS."^3.3.18"keeps the bump inside 3.x.Verification
pnpm why nanoidreports a singlenanoid@3.3.18, consumed only bypostcss;pnpm typecheckclean;pnpm buildgreen across all six locales — which exercises postcss end to end, the only consumer.🤖 Generated with Claude Code