Android: Add simple creation and attestation of a credential#3
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Android quickstart “track” that demonstrates creating a basic WebAuthn credential and then performing an assertion, to make credential onboarding easier within the existing track-based sample app.
Changes:
- Introduces a new
CredentialTrackViewModelto run makeCredential + getAssertion and expose results to UI state. - Adds a new Compose UI (
CredentialTrackView) to display the created options/responses. - Wires the new track into the track selector/navigation and adds a new string resource for the track title.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| quickstart/android/app/src/main/res/values/strings.xml | Adds a new track title string for the credential creation track. |
| quickstart/android/app/src/main/java/com/yubico/eap/quickstart/track/credentials/CredentialTrackViewModel.kt | Implements credential creation + assertion flow and exposes results via Compose state. |
| quickstart/android/app/src/main/java/com/yubico/eap/quickstart/track/credentials/CredentialTrackView.kt | Adds UI to render the credential flow results and handle in-progress/error states. |
| quickstart/android/app/src/main/java/com/yubico/eap/quickstart/QuickstartVM.kt | Registers the new track and shifts track indices accordingly. |
| quickstart/android/app/src/main/java/com/yubico/eap/quickstart/MainActivity.kt | Adds the new track to the selection list and routes to its view/model. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to smoothen the entry into the world of credentials: First create a simple one and then use extensions ...