Issue fixing#87
Open
GrinlexGH wants to merge 5 commits into
Open
Conversation
Author
|
Im not sure about private section of the module |
|
A small nitpick: would it be useful to split this PR up into individual PRs that each addresses one of the issues quoted? It might be easier for review as well. |
This reverts commit f70c1eb.
Author
|
I see the point of moving only the addition of abi breaking style to a separate pr, because everything else is a minor change, literally three small fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
volk.hinclude whenVMA_HPP_ENABLE_VOLKdefined | Volk integration for c++20 module #85