fix,refactor(puppeth,config): support privatechain generator v3

[wanwiset25]

Proposed changes

Changes to support privatechain generator v3

• activate forks and update config values to match next mainnet release
• fix puppeth bug not importing foundationWalletAddress properly
• refactor reward calculation for protector and observer nodes

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Changes that don't change source code or tests
• docs: Documentation only changes
• feat: A new feature
• fix: A bug fix
• perf: A code change that improves performance
• refactor: A code change that neither fixes a bug nor adds a feature
• revert: Revert something
• style: Changes that do not affect the meaning of the code
• test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2b5aa433-17c6-4671-967e-816b7162deb7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

Supports private-chain generator v3 while updating local/test network protocol settings.

Changes:

• Activates newer forks and adjusts localnet node limits.
• Revises reward calculations and imports foundation wallet addresses.
• Exempts bootstrap timeout certificates from verification.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
params/config_networks.go	Updates local and mock-chain protocol configuration.
cmd/puppeth/wizard_genesis.go	Revises rewards and foundation wallet handling.
consensus/XDPoS/engines/engine_v2/timeout.go	Identifies bootstrap timeout certificates.
consensus/XDPoS/engines/engine_v2/engine.go	Skips verification for bootstrap certificates.
consensus/tests/engine_v2_tests/sync_info_test.go	Tests bootstrap certificate behavior.

Suppressed comments (2)

params/config_networks.go:742

• TestXDPoSMockChainConfigDeclaresModernForks explicitly requires Osaka to be non-nil and active from genesis (params/config_networks_test.go:81-82). Setting it to nil guarantees a test failure; either preserve block 0 or update the test contract if deactivation is intentional.

		OsakaBlock:                  nil,

cmd/puppeth/wizard_genesis.go:292

• The new foundation-address import path has no regression assertion: the existing puppeth integration test omits this field and only checks deployed contract code. Add a custom address to its YAML and assert that the generated FoundationWalletAddr matches it so the original import bug cannot recur.

			genesis.Config.XDPoS.FoundationWalletAddr = common.HexToAddress(input.FoundationWalletAddress)

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.