Bug fixes for requant_decoupled pr. - #1666
Merged
preusser-amd merged 1 commit intoAug 26, 2026
Merged
Conversation
…am. Requant changed so that bias now shares the scale memstream. This was updated on the FINN side so that numbering is correct again.
Collaborator
|
Thanks, @sgerber-amd! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following test failed:
pytest tests/fpgadataflow/test_fpgadataflow_finnloop.py::test_finnloop_end2end_mlo_requant
This PR fixes this issue by aligning the numbering or parameter streams to align with the changes made to the requant memstream, so that the bias sharing the scale memstream no longer shifts the port and descriptor indices.
This setup now passes the following tests with certainty:
tests/fpgadataflow/test_fpgadataflow_finnloop.py
tests/fpgadataflow/test_fpgadataflow_requant.py
tests/transformation/test_loop_rolling.py
tests/fpgadataflow/test_fifosizing.py
tests/fpgadataflow/test_fpgadataflow_ipstitch.py
tests/end2end/test_end2end_cybsec_mlp.py