6不6 - #6
Open
ggboyxkw666 wants to merge 1 commit into
Open
Conversation
XiaoCow666
approved these changes
Sep 3, 2026
XiaoCow666
left a comment
Owner
There was a problem hiding this comment.
已对照 main 分支的 app.py、config.py、wsgi.py、database_maintenance.py、routes/thinking.py、tasks/submission_tasks.py、utils/sandbox_runner.py 和 README.md 逐项核验。
结论:文档覆盖项目定位、架构、核心链路、运行/测试、风险与未知项;“已确认 / 推断 / 待验证”的边界也写得清楚,主要结论与当前实现相符,阶段一交付标准已满足,批准合并。
阶段二建议优先处理一个具体的评测安全缺口:sandbox 当前使用 capture_output=True,子进程结束后才对 stdout 做 [:4096] 截取,因此 4096 只是最终保存长度,并不是子进程输出的内存上限。恶意程序在 5 秒内持续输出仍可能造成不必要的内存增长;stderr 也有类似问题。
建议后续实现:对子进程 stdout/stderr 做有界读取,超过上限立即终止并返回明确状态;补充回归测试,并在部署说明中明确该限制与尚未完成的 OS 级隔离。这个问题不阻塞本次文档 PR,但值得作为下一阶段的具体落地项。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.