Repository navigation
Update footer script for service status - #1070
Open
PythonSmall-Q wants to merge 1 commit into
Open
PythonSmall-Q wants to merge 1 commit into
PythonSmall-Q wants to merge 1 commit into
Conversation
Signed-off-by: Shan Wenxiao <seanoj_noreply@yeah.net>
Deploying xmoj-script-dev-channel with
|
| Latest commit: |
4a0ee2a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f9579846.xmoj-script-dev-channel.pages.dev |
| Branch Preview URL: | https://statuspage.xmoj-script-dev-channel.pages.dev |
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the site footer to link to the new service-status dashboard and replaces the legacy embedded status widget with the new provider’s configurable widget, including five-minute polling and reduced display of operational messages. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
hendragon-bot
Bot
added
the
website
PythonSmall-Q
requested review from
boomzero
and
a balanced review from Copilot
October 17, 2026 04:49
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="index.html">
<violation number="1" location="index.html:323">
P3: The new "服务状态" footer link exists only on the homepage. The other pages' footers (404.html, terms.html, child-protection.html, privacy.html) use the same `footer-links` list and the comment says they should stay in sync. Add the link to those footers too, or drop the comment's consistency claim.</violation>
<violation number="2" location="index.html:338">
P2: The homepage now loads the status widget from `status.xmoj-script.uk` instead of Statuspage. The provider table in `privacy.html` still lists "Statuspage（Atlassian）" as the service that shows status on the homepage. Update that row (or add the new host) so the disclosure matches the actual third-party requests.</violation>
</file>
Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack
View guided diff | Turn on auto-fix | Re-trigger cubic
|
|
||
| <script | ||
| defer | ||
| src="https://status.xmoj-script.uk/embed.js" |
Contributor
There was a problem hiding this comment.
P2: The homepage now loads the status widget from status.xmoj-script.uk instead of Statuspage. The provider table in privacy.html still lists "Statuspage（Atlassian）" as the service that shows status on the homepage. Update that row (or add the new host) so the disclosure matches the actual third-party requests.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At index.html, line 338:
<comment>The homepage now loads the status widget from `status.xmoj-script.uk` instead of Statuspage. The provider table in `privacy.html` still lists "Statuspage（Atlassian）" as the service that shows status on the homepage. Update that row (or add the new host) so the disclosure matches the actual third-party requests.</comment>
<file context>
@@ -331,7 +332,15 @@ <h3 class="h5">赞助</h3>
+
+ <script
+ defer
+ src="https://status.xmoj-script.uk/embed.js"
+ data-service="all"
+ data-position="top-right"
</file context>
| <div class="container"> | ||
| <ul class="footer-links"> | ||
| <li><a href="https://docs.xmoj-script.uk" target="_blank" rel="noopener noreferrer">文档</a></li> | ||
| <li><a href="https://status.xmoj-script.uk/" target="_blank" rel="noopener noreferrer">服务状态</a></li> |
Contributor
There was a problem hiding this comment.
P3: The new "服务状态" footer link exists only on the homepage. The other pages' footers (404.html, terms.html, child-protection.html, privacy.html) use the same footer-links list and the comment says they should stay in sync. Add the link to those footers too, or drop the comment's consistency claim.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At index.html, line 323:
<comment>The new "服务状态" footer link exists only on the homepage. The other pages' footers (404.html, terms.html, child-protection.html, privacy.html) use the same `footer-links` list and the comment says they should stay in sync. Add the link to those footers too, or drop the comment's consistency claim.</comment>
<file context>
@@ -320,6 +320,7 @@ <h3 class="h5">赞助</h3>
<div class="container">
<ul class="footer-links">
<li><a href="https://docs.xmoj-script.uk" target="_blank" rel="noopener noreferrer">文档</a></li>
+ <li><a href="https://status.xmoj-script.uk/" target="_blank" rel="noopener noreferrer">服务状态</a></li>
<li><a href="messages.html">短消息在线看</a></li>
<li><a href="privacy.html">隐私说明</a></li>
</file context>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="index.html" line_range="338" />
<code_context>
+
+ <script
+ defer
+ src="https://status.xmoj-script.uk/embed.js"
+ data-service="all"
+ data-position="top-right"
</code_context>
<issue_to_address>
**Privacy notice names old provider**
When `status.xmoj-script.uk` is operated by a provider other than Atlassian, `privacy.html` still identifies “Statuspage（Atlassian）” as the service displaying status and lists its data handling, so the notice names the wrong processor and misleads users about who receives their requests.
Update the privacy notice to identify the actual status-service provider and its data handling.
</issue_to_address>
### Comment 2
<location path="index.html" line_range="323" />
<code_context>
<div class="container">
<ul class="footer-links">
<li><a href="https://docs.xmoj-script.uk" target="_blank" rel="noopener noreferrer">文档</a></li>
+ <li><a href="https://status.xmoj-script.uk/" target="_blank" rel="noopener noreferrer">服务状态</a></li>
<li><a href="messages.html">短消息在线看</a></li>
<li><a href="privacy.html">隐私说明</a></li>
</code_context>
<issue_to_address>
**Status link missing elsewhere**
When a visitor opens a page other than `index.html`, `404.html`, `privacy.html`, `terms.html`, and `child-protection.html` retain footers without the status link, so visitors on those pages cannot reach the status page from the footer.
Add the status link to the footer on each of those pages as well.
</issue_to_address>Sourcery assessment
Approval pending. 2 findings to address first.
Blocking findings: index.html:338, index.html:323
|
|
||
| <script | ||
| defer | ||
| src="https://status.xmoj-script.uk/embed.js" |
Contributor
There was a problem hiding this comment.
🟡 Medium · Privacy notice names old provider
When status.xmoj-script.uk is operated by a provider other than Atlassian, privacy.html still identifies “Statuspage（Atlassian）” as the service displaying status and lists its data handling, so the notice names the wrong processor and misleads users about who receives their requests.
Update the privacy notice to identify the actual status-service provider and its data handling.
Prompt for AI agents
In `index.html` at line 338:
**Privacy notice names old provider**
When `status.xmoj-script.uk` is operated by a provider other than Atlassian, `privacy.html` still identifies “Statuspage（Atlassian）” as the service displaying status and lists its data handling, so the notice names the wrong processor and misleads users about who receives their requests.
Update the privacy notice to identify the actual status-service provider and its data handling.| <div class="container"> | ||
| <ul class="footer-links"> | ||
| <li><a href="https://docs.xmoj-script.uk" target="_blank" rel="noopener noreferrer">文档</a></li> | ||
| <li><a href="https://status.xmoj-script.uk/" target="_blank" rel="noopener noreferrer">服务状态</a></li> |
Contributor
There was a problem hiding this comment.
🟡 Medium · Status link missing elsewhere
When a visitor opens a page other than index.html, 404.html, privacy.html, terms.html, and child-protection.html retain footers without the status link, so visitors on those pages cannot reach the status page from the footer.
Add the status link to the footer on each of those pages as well.
Prompt for AI agents
In `index.html` at line 323:
**Status link missing elsewhere**
When a visitor opens a page other than `index.html`, `404.html`, `privacy.html`, `terms.html`, and `child-protection.html` retain footers without the status link, so visitors on those pages cannot reach the status page from the footer.
Add the status link to the footer on each of those pages as well.
Member
|
主站如果炸了这个statuspage肯定也会炸 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
How does this PR accomplish the above?:
Does this PR need a documentation update?:
By submitting this pull request, I confirm the following:
devfor XMOJ-Script,masterfor everything else).git rebase)/webpages)/webpages)Summary by cubic
Updates the footer status indicator to use the XMOJ Script status service and adds a link to its status page.
Written for commit 4a0ee2a. Summary will update on new commits.
Summary by Sourcery
Update the footer service-status integration to point users to the current status service.
New Features:
Bug Fixes: