Build/Test Tools: Reference the smoke check action from trunk. - #13389
Draft
adimoldovan wants to merge 3 commits into
Draft
Build/Test Tools: Reference the smoke check action from trunk.#13389adimoldovan wants to merge 3 commits into
adimoldovan wants to merge 3 commits into
Conversation
…s site. The action serves an installed single site with PHP's built-in web server. It checks the front end, REST API, database upgrade page, 404 handling, login, dashboard, and server log. The script lives in `smoke-check.sh`, which reads as a bash file instead of a 100-line inline `run:` block. actionlint shellchecks inline `run:` blocks, but it does not read composite actions. The workflow linter now runs shellcheck over the scripts under `.github/actions`, and it triggers on changes to that directory.
Upgrade testing calls the action instead of carrying the script inline. Installation testing runs the same check after it installs a site. Both skip multisite, because a network keeps its domain in wp-config.php and the database, not in an option the script can move to a temporary port. The jobs check the action out into `ci-tools` with a sparse checkout, and call it by relative path. Each run then uses the script from the branch under test. A follow-up changes the reference to `@trunk`, which the release branches need, and drops the checkout. Installation testing also gets a longer timeout for the added step.
The release branches call `reusable-upgrade-testing.yml@trunk`. Trunk's reusable workflow then runs with `github.ref` set to the release branch, where `.github/actions` does not exist, so a relative reference fails there. The workflows point at the action on trunk instead, and drop the checkout. A pull request now resolves the action from trunk rather than from the branch, so the path filters for the action cover pushes only.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| - name: Post-install smoke check | ||
| # A network's domain lives in wp-config.php and the database, not just an option. | ||
| if: ${{ ! matrix.multisite }} | ||
| uses: WordPress/wordpress-develop/.github/actions/smoke-check@trunk |
| echo 'ok server log' | ||
| env: | ||
| SITE_PORT: 8889 | ||
| uses: WordPress/wordpress-develop/.github/actions/smoke-check@trunk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Points the smoke check step at the action on trunk, and drops the checkout that the relative reference needed.
Trac ticket: https://core.trac.wordpress.org/ticket/66036
Depends on #13388. Land that first: until the action is on trunk,
@trunkdoes not resolve, and the runner resolves everyuses:during job setup.The 6.9, 7.0 and 7.1 branches call
reusable-upgrade-testing.yml@trunk. Trunk's reusable workflow then runs withgithub.refset to the release branch, where.github/actionsdoes not exist, so a relative reference fails on every release branch job. Pointing at the action on trunk also matches how those branches already take their CI from trunk.The path filters for
.github/actions/smoke-check/**now cover pushes only. A pull request resolves the action from trunk rather than from the branch, so a pull request run would report on the old script.Code scanning
This adds two
unpinned-usesalerts, one for each reference, requiring a hash pin, but it does not fit here:WordPress/wordpress-developat trunk, never from a fork, so a pull request cannot inject action code.WordPress/props-bot-action@trunkinprops-bot.ymlcarries the same alert today.Testing instructions
Once #13388 is on trunk, the Installation Tests and Upgrade Tests checks here resolve the action from trunk and run it. Each single site row prints seven
oklines; multisite rows skip the step.Before that, both workflows fail at job setup with
Unable to resolve action. That is expected, and it is the reason for the two pull requests.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: The workflow changes and iterative code review. I reviewed and tested the result.