Skip to content

Administration: Correct the message shown when build files are unavailable - #13365

Open
i-am-chitti wants to merge 1 commit into
WordPress:trunkfrom
i-am-chitti:fix/66022-build-files-message
Open

Administration: Correct the message shown when build files are unavailable#13365
i-am-chitti wants to merge 1 commit into
WordPress:trunkfrom
i-am-chitti:fix/66022-build-files-message

Conversation

@i-am-chitti

Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/66022

The Font Library and Connectors screens tell the user to run npm install when build files are missing. That was correct when 61492 added a postinstall hook that built the assets; 62321 removed it and the messages were never updated. The two strings are also inconsistent — one says "Gutenberg build files", the other "build files".

Changes

  • npm installnpm run build in both messages.
  • Dropped the "Gutenberg" reference so both strings read consistently.
  • Moved the command into a sprintf() placeholder with a translators comment, per src/index.php.

Screenshots

Font Library

Before After
font-library-before font-library-after

Connectors

Before After
options-connectors-before options-connectors-after

Use of AI

AI assistance: Yes
Tool(s): Claude Code
Model(s): Sonnet 5
Used for: Go through changesets

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props iamchitti, afercia.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

'<p>' . sprintf(
/* translators: %s: npm run build */
__( 'The Font Library requires build files. Please run %s to build the necessary files.' ),
'<code>npm run build</code>'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my development environment, npm run build isn't enough and I have to run also npm run dev. Given this is a message for developers, what about entirely removing the command to use and just provide a more generic message? Developers know what to do. Thoughts?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch.

I looked at dropping the command and linking to docs instead, like src/index.php does. That doesn't work: the handbook page it links has nothing about building, and the other mentions are old make/core posts using the older grunt build --dev form. The one accurate source is this repo's README. We could link that on GitHub, but core has no precedent for it, every user-facing doc link goes to the handbook, so I would rather not introduce that here.

So, three options:

A. Name the command that fits a dev environment:

The Font Library requires build files. Please run npm run build:dev to build the necessary files.

A caveat that this assumes npm install has already run.

B. Drop the command, as you suggested:

The Font Library requires build files. Please build WordPress and try again.

C. Generic wording plus the handbook link:

The Font Library requires build files. Please build WordPress and try again. Learn more about setting up your local development environment.

Last sentence will be hyperlinked to a doc about build toolchain. Currently, there is none.

@afercia

afercia commented Sep 4, 2026

Copy link
Copy Markdown
Member

@i-am-chitti thanks for exploring all the options. Personally, I'd suggest to just drop the command and use a generic sentence, because:

  • The location of a linked resource may change at any time and a link to it would become broken (and unnoticed).
  • The command itself may change in the future and maintaining these messages may be missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants