Skip to content

Build/Test Tools: Use strict assertions in various test cases#12583

Open
Soean wants to merge 1 commit into
WordPress:trunkfrom
Soean:tests/use-strict-assertions
Open

Build/Test Tools: Use strict assertions in various test cases#12583
Soean wants to merge 1 commit into
WordPress:trunkfrom
Soean:tests/use-strict-assertions

Conversation

@Soean

@Soean Soean commented Jul 17, 2026

Copy link
Copy Markdown
Member

What

Replaces loose assertions (assertEquals() / assertNotEquals()) with their strict counterparts (assertSame() / assertNotSame()) across a number of PHPUnit test files.

Why

Strict assertions additionally check the type of the compared values, making the tests more robust against unintended type coercion and better documenting the expected return types of the functions under test.

Testing

All affected test files pass locally: OK (71 tests, 669 assertions).

Trac ticket: https://core.trac.wordpress.org/ticket/64895


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Replace `assertEquals()`/`assertNotEquals()` with `assertSame()`/`assertNotSame()` across several test files. Strict assertions also verify the value type, catching unintended type coercion.

For assertions comparing values that may differ in type (e.g. `ceil()` returning a float), the loose comparison is intentionally retained.
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props soean.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant