Build/Test Tools: Use strict assertions in various test cases#12583
Build/Test Tools: Use strict assertions in various test cases#12583Soean wants to merge 1 commit into
Conversation
Replace `assertEquals()`/`assertNotEquals()` with `assertSame()`/`assertNotSame()` across several test files. Strict assertions also verify the value type, catching unintended type coercion. For assertions comparing values that may differ in type (e.g. `ceil()` returning a float), the loose comparison is intentionally retained.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
What
Replaces loose assertions (
assertEquals()/assertNotEquals()) with their strict counterparts (assertSame()/assertNotSame()) across a number of PHPUnit test files.Why
Strict assertions additionally check the type of the compared values, making the tests more robust against unintended type coercion and better documenting the expected return types of the functions under test.
Testing
All affected test files pass locally:
OK (71 tests, 669 assertions).Trac ticket: https://core.trac.wordpress.org/ticket/64895
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.