Security: Use aria-controls attribute with safe $( '#' + id ) selector pattern avoiding unsafe use of href

[SainathPoojary]

The contextual help tab click handler passed the raw href attribute to jQuery's $(), which accepts both CSS selectors and raw HTML.

Fix: Use aria-controls with the $( '#' + id ) pattern, the same convention used elsewhere in the same file and across admin JS (privacy-tools.js, site-health.js).

Trac ticket: #65574

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.