-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Media: Add an opt-in filter to generate animated image sub-sizes #12572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adamsilverstein
wants to merge
2
commits into
WordPress:trunk
Choose a base branch
from
adamsilverstein:add/animated-image-subsizes-filter
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+82
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -1207,6 +1207,64 @@ public function test_get_index() { | |||||||||
| $this->assertArrayHasKey( 'site_icon_url', $data ); | ||||||||||
| } | ||||||||||
|
|
||||||||||
| /** | ||||||||||
| * @ticket 65656 | ||||||||||
| * | ||||||||||
| * @covers WP_REST_Server::get_index | ||||||||||
| */ | ||||||||||
| public function test_get_index_should_include_animated_image_subsizes(): void { | ||||||||||
| $user_id = self::factory()->user->create( array( 'role' => 'administrator' ) ); | ||||||||||
| $this->assertIsInt( $user_id ); | ||||||||||
| wp_set_current_user( $user_id ); | ||||||||||
| add_filter( 'wp_client_side_media_processing_enabled', '__return_true' ); | ||||||||||
|
|
||||||||||
| $server = new WP_REST_Server(); | ||||||||||
| $request = new WP_REST_Request( 'GET', '/' ); | ||||||||||
| $index = $server->dispatch( $request ); | ||||||||||
| $data = $index->get_data(); | ||||||||||
| $this->assertIsArray( $data ); | ||||||||||
|
|
||||||||||
| $this->assertArrayHasKey( 'animated_image_subsizes', $data ); | ||||||||||
| $this->assertFalse( $data['animated_image_subsizes'] ); | ||||||||||
| } | ||||||||||
|
|
||||||||||
| /** | ||||||||||
| * @ticket 65656 | ||||||||||
| * | ||||||||||
| * @covers WP_REST_Server::get_index | ||||||||||
| */ | ||||||||||
| public function test_get_index_should_not_include_animated_image_subsizes_without_caps(): void { | ||||||||||
| add_filter( 'wp_client_side_media_processing_enabled', '__return_true' ); | ||||||||||
|
|
||||||||||
| $server = new WP_REST_Server(); | ||||||||||
| $request = new WP_REST_Request( 'GET', '/' ); | ||||||||||
| $index = $server->dispatch( $request ); | ||||||||||
| $data = $index->get_data(); | ||||||||||
| $this->assertIsArray( $data ); | ||||||||||
|
|
||||||||||
| $this->assertArrayNotHasKey( 'animated_image_subsizes', $data ); | ||||||||||
| } | ||||||||||
|
|
||||||||||
| /** | ||||||||||
| * @ticket 65656 | ||||||||||
| * | ||||||||||
| * @covers WP_REST_Server::get_index | ||||||||||
| */ | ||||||||||
| public function test_get_index_should_honor_animated_image_subsizes_filter(): void { | ||||||||||
| $user_id = self::factory()->user->create( array( 'role' => 'administrator' ) ); | ||||||||||
| $this->assertIsInt( $user_id ); | ||||||||||
| wp_set_current_user( $user_id ); | ||||||||||
|
Comment on lines
+1254
to
+1256
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Reuse admin that already created in |
||||||||||
| add_filter( 'wp_client_side_media_processing_enabled', '__return_true' ); | ||||||||||
| add_filter( 'wp_generate_animated_image_subsizes', '__return_true' ); | ||||||||||
|
|
||||||||||
| $server = new WP_REST_Server(); | ||||||||||
| $request = new WP_REST_Request( 'GET', '/' ); | ||||||||||
| $index = $server->dispatch( $request ); | ||||||||||
| $data = $index->get_data(); | ||||||||||
|
|
||||||||||
| $this->assertTrue( $data['animated_image_subsizes'] ); | ||||||||||
| } | ||||||||||
|
|
||||||||||
| /** | ||||||||||
| * @ticket 57902 | ||||||||||
| * | ||||||||||
|
|
||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I just commented at WordPress/gutenberg#80385 as well,
animated_image_subsizessounds more like an array than a boolean. Maybe we can prefix the field withgenerate_as well or so.