Skip to content

65655 functions wp die#12571

Open
pbearne wants to merge 5 commits into
WordPress:trunkfrom
pbearne:65655-functions-wp_die
Open

65655 functions wp die#12571
pbearne wants to merge 5 commits into
WordPress:trunkfrom
pbearne:65655-functions-wp_die

Conversation

@pbearne

@pbearne pbearne commented Jul 16, 2026

Copy link
Copy Markdown

This PR introduces dedicated unit tests for the wp_die() function and its primary HTML handler _default_wp_die_handler() in wp-includes/functions.php.

Following the project's testing guidelines, the tests are split into two files:
•tests/phpunit/tests/functions/wpDie.php: Focuses on handler selection logic (Standard vs. Ajax), handling of WP_Error objects, and ensuring the correct callback is triggered via filters.
•tests/phpunit/tests/functions/_defaultWpDieHandler.php: Verifies the HTML output generated by the default handler, including the error message, title, additional error lists, and action links.

The tests use WPDieException to intercept execution termination and MockAction to verify filter interactions.

Trac ticket: https://core.trac.wordpress.org/ticket/65655

AI Disclosure:
•AI assistance: Yes
•Tool(s): Junie (JetBrains)
•Model(s): gemini-3-flash-preview
•Used for: Code analysis, test implementation, and workflow management.

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @pbearne@git.wordpress.org.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props pbearne, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Comment thread tests/phpunit/tests/functions/wpDie.php
Refactor wp_die_handler filter for better readability.
@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants