Repository navigation
feat(query)!: select meeting mentions by URL and started_at before limiting - #244
Merged
Merged
Conversation
leemour
force-pushed
the
fix/remaining-list-queries
branch
from
October 24, 2026 21:17
a5b7b75 to
67888ef
Compare
WC-CMD-19, WC-CMD-20: derive fields from the shared meeting-link schema, reject unsupported predicates before acquiring a reader and pass URL selection to the shared service. Requires the additive native-selector release after cli-core #1910.
WC-CMD-12, WC-CMD-20: mentions list advertises the meeting-link schema fields, so its --since-time/--until-time flags duplicated the query. The meeting window is now the native query field started_at (`zm personal mentions list started_at>=30d`); the flags are removed from mentions list without an alias and stay on review and stats. Exclusive range ends become the inclusive bounds the reader takes. Pins registry cli-core 0.412.0 (tag v0.412.0). Types, lint, command lint, contracts, generation, docs and 617 tests pass; the matrix has 0 missing. scripts/acceptance.test.ts timed out on npm install in the local sandbox and is left to CI. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
leemour
force-pushed
the
fix/remaining-list-queries
branch
from
October 24, 2026 23:55
67888ef to
acc4645
Compare
WC-DOC-15: 0.43.0 is released, so the mentions URL and started_at notes move to a new Unreleased section. Query validation already refuses operators a field does not declare, so the second operator check in linkSelection could never run and is removed; event_id:0 is now refused before a reader in the tests. Statement coverage is back above 97%. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
leemour
changed the title
leemour
marked this pull request as ready for review
October 25, 2026 01:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meeting mentions select a URL and a meeting window inside the shared link reader, before result limits.
What
event_id,projectandtopicselectors.mentions listtakes the meeting window as the native query fieldstarted_at(zm personal mentions list started_at>=30d). Its--since-timeand--until-timeoptions are removed, with no alias. Once the schema fields arrived, the command lint flagged them as filter flags that duplicate the query (WC-CMD-12).reviewand the stats commands keep the flags.timeBoundsdrops inclusivity; that is reported on cli-messaging: merges into main and release runs — announce here first cli-core#849.@wirecat/cli-core0.412.0 (tag v0.412.0).Rules: WC-CMD-12, WC-CMD-19, WC-CMD-20, WC-DOC-15.
Testing
srctests. Statement coverage is 97.04%. The test matrix has 0 missing entries.scripts/acceptance.test.tstimed out onnpm installin the local sandbox; CI ran it.list-without-queryexemptions.🤖 Generated with Claude Code