Repository navigation
docs(code-design): services see MessengerTraits and import nothing from cli/ - #242
Merged
Merged
Conversation
…om cli/ cli-core #1281 moved the service layers off src/cli/. The page now says so in EN, RU and ES: - ports/ holds traits.ts and app.ts beside the adapter contract; services and the layers beside them may not import cli/. - domain/ is almost the bottom: two types from search/, task kinds from tasks/. - servicesFor builds per command run and per MCP call, not once. - Convention 2: a use case takes the narrowest dependency it needs; 25 of 87 service files take only the store, 36 take ServiceDeps. - The limit about services knowing the CLI is replaced by the one left: connect/accountOf/guard/diagnose take a commander Command. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the Code design page in English, Russian and Spanish to match cli-core #1281 (re-review step 4).
ports/now holds the adapter contract,traits.ts(what a service reads of the messenger) andapp.ts. Services, plusreplies/,attachments/,moderation/,models/andanalysis/, may not importcli/.domain/is described as almost the bottom, since it still reads two types fromsearch/and the task kinds fromtasks/.MessengerTraits;Messengeradds the parts only the CLI uses.servicesFor: it builds the services per command run and per MCP call, not once. The old line that commands and MCP always give the same answer is replaced by: both call the same service functions.main, 25 of 87 service files take only the store and 36 takeServiceDeps.connect,accountOf,guardanddiagnosestill take a commanderCommand.cli/move with it.Checks:
pnpm docs:lintandpnpm ci:quickpass. I did not runcheck:linkslocally: it needs a full site build (out/). The one new link points tosrc/ports/traits.tsat cli-core80616b38.beautiful-mermaid.🤖 Generated with Claude Code