Repository navigation
fix(parity): wa lacks the sync-first options a pushed-history messenger is not offered - #1428
Merged
Merged
Conversation
…er is not offered 0.315.0 stopped offering --sync-first, --sync-time, --max-chats and --max-messages to a messenger with history: "store"; wa's column was placed from a build before that, so the 0.316.0 release's Parity job failed on wa. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Unblock the 0.316.0 release: its Parity job failed on whatsapp-cli (run 39022464895).
Why
0.315.0 (#1423) stopped offering
--sync-first,--sync-time,--max-chatsand--max-messagesto a messenger withhistory: "store". #1424 placed wa's column from a wa build that predates 0.315.0, so 20 options saidallthat wa no longer has.What
Those 20 options are now
in: [max, tg], with the reason that a pushed-history messenger has nothing to sync first. The option catalogue is re-rendered, and the changelog has a line under Unreleased.Testing
wa main (
0f17395) was built against this branch's packed tarball:cli-core-parity wareports 0 differences and--pagespasses.manifestProblemsreports 0. The parity and steps tests pass.Reviewed against the review checklist — §B for code.
🤖 Generated with Claude Code