Fix mouse scroll bindings not scrolling - #665
Draft
Xnick417x wants to merge 1 commit into
Draft
Conversation
A button bound to Mouse Scroll Up/Down pressed X11 button 4/5 on touch down and held it until release, so it only ever produced one wheel notch and never repeated. Because Pointer.setButton is edge-triggered, a latched scroll button also silently dropped every other scroll source (touchpad two-finger scroll, physical wheel). Scroll bindings now emit press+release together as a single notch and repeat while held (350ms delay, 90ms interval), stopping on release. Also drop the delta-0 MOUSEEVENTF_WHEEL sent on every scroll release in relative-mouse mode; the notch is fully delivered by the press.
Xnick417x
marked this pull request as draft
July 27, 2026 01:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A button bound to Mouse Scroll Up/Down pressed X11 button 4/5 on touch down and held it until release, so it only ever produced one wheel notch and never repeated. Because Pointer.setButton is edge-triggered, a latched scroll button also silently dropped every other scroll source (touchpad two-finger scroll, physical wheel).
Scroll bindings now emit press+release together as a single notch and repeat while held (350ms delay, 90ms interval), stopping on release. Also drop the delta-0 MOUSEEVENTF_WHEEL sent on every scroll release in relative-mouse mode; the notch is fully delivered by the press.