Skip to content

fix: verify live GitHub bodies and prepare v1.3.4 - #392

Merged
Wibias merged 9 commits into
mainfrom
release/1.3.4
Aug 28, 2026
Merged

fix: verify live GitHub bodies and prepare v1.3.4#392
Wibias merged 9 commits into
mainfrom
release/1.3.4

Conversation

@Wibias

@Wibias Wibias commented Aug 28, 2026

Copy link
Copy Markdown
Owner

Summary

Runtime fix

Body-bearing social mutations now re-read the authoritative GitHub object after a successful write. Direct receipt IDs are used when available; otherwise collection fallback requires the exact idempotency marker, the authenticated GitHub actor, and the reply parent where applicable. The postcondition then requires the live body to match the exact intended markdown.

The router deliberately gives postcondition verification the unfiltered body-safe runner rather than the receipt-filtered runner, so malformed live bodies cannot disappear from verification through idempotency filtering.

TDD / regression evidence

The initial test-only head was RED on the intended missing-live-reread behavior.

During GREEN work, the retained forged-actor regression exposed two compatibility assumptions rather than a reason to weaken the new invariant:

  1. the postcondition initially introduced an incompatible JSON actor lookup; it now reuses the canonical readAuthenticatedActor() contract (gh api user --jq .login), and
  2. the forged-marker fixture now models remote state across the write: before publication only the attacker record exists; after the real write the authenticated actor's exact published body is visible and must satisfy the new postcondition.

On the production/release path, the canonical Node 24 repository checks and Node 22 compatibility pass with the strengthened forged-actor and live-body regressions.

Release 1.3.4

Base release: v1.3.3 / 69884f3ea72e035c080547b076d907e077a33c3d

The release notes cover the complete consumer-facing delta since that tag:

package.json, README current-state/release notes, and CHANGELOG.md are prepared for 1.3.4.

Tag creation, GitHub Release publication, release assets, npm publication, and merge of this PR are not part of this PR and remain separately authorized.

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 65bb280f-b3ed-46e6-8743-e135441c433a


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Wibias
Wibias marked this pull request as ready for review August 28, 2026 23:31
@Wibias
Wibias enabled auto-merge August 28, 2026 23:31
@Wibias
Wibias merged commit bb3bd8f into main Aug 28, 2026
11 checks passed
@Wibias
Wibias deleted the release/1.3.4 branch August 28, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant